Skip to content

Add Scapy-focused code review guidance - #5239

Open
polybassa wants to merge 6 commits into
secdev:masterfrom
polybassa:scapy-code-review-guidance
Open

polybassa wants to merge 6 commits into
secdev:masterfrom
polybassa:scapy-code-review-guidance

Conversation

@polybassa

Copy link
Copy Markdown
Contributor

Add a Scapy-specific review skill and checklist covering wire-format evidence, field and binding patterns, malformed-packet compatibility, lifecycle, UTScapy, and actionable findings. Link it from AGENTS.md and keep potential security disclosures on the private reporting path.

AI-Assisted: yes (GPT-6)

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.41%. Comparing base (aee4577) to head (5eb5e27).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5239       +/-   ##
===========================================
+ Coverage   45.97%   80.41%   +34.44%     
===========================================
  Files         376      376               
  Lines       98371    98405       +34     
===========================================
+ Hits        45223    79135    +33912     
+ Misses      53148    19270    -33878     

see 288 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@polybassa
polybassa force-pushed the scapy-code-review-guidance branch from aea9ca6 to f9428ac Compare October 20, 2026 07:10
Nils Weiss added 2 commits October 24, 2026 18:32
Add a review skill and checklist for protocol semantics, packet behavior, regressions, tests, performance, and evidence. Point AGENTS.md to the skill and preserve the private path for security findings.

AI-Assisted: yes (GPT-6)
@gpotter2
gpotter2 force-pushed the scapy-code-review-guidance branch from 3fa6c75 to 5eb5e27 Compare October 24, 2026 16:32
Comment thread .github/skills/scapy-code-review/references/review-checklist.md
Comment thread .github/skills/scapy-code-review/references/review-checklist.md
Comment thread .github/skills/scapy-code-review/references/review-checklist.md
Comment thread .github/skills/scapy-code-review/references/review-checklist.md
gpotter2
gpotter2 previously approved these changes Oct 24, 2026

@gpotter2 gpotter2 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments otherwise LGTM !

Co-authored-by: Gabriel <10530980+gpotter2@users.noreply.github.com>
polybassa and others added 3 commits October 24, 2026 22:10
Co-authored-by: Gabriel <10530980+gpotter2@users.noreply.github.com>
Co-authored-by: Gabriel <10530980+gpotter2@users.noreply.github.com>
Co-authored-by: Gabriel <10530980+gpotter2@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants