Repository navigation
Conversation
ctypes may return WAIT_FAILED as -1, which select_objects() treats as an input index and can report the last object ready. Raise the Windows error and close temporary Winsock events on failed waits. AI-Assisted: yes (GPT-6)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5238 +/- ##
==========================================
+ Coverage 78.01% 81.10% +3.08%
==========================================
Files 376 394 +18
Lines 98351 98752 +401
==========================================
+ Hits 76725 80088 +3363
+ Misses 21626 18664 -2962
🚀 New features to boost your workflow:
|
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, ctypes can return WAIT_FAILED as -1, so select_objects() may treat it as an input index and report an unreadable object as ready. Raise the Windows error for failed waits and close temporary Winsock events before propagating it.
AI-Assisted: yes (GPT-6)