Repository navigation
automaton, test: fix Windows select_objects index mapping and stabilize TLS test timeouts - #5227
Closed
BenGardiner wants to merge 1 commit into
Closed
BenGardiner wants to merge 1 commit into
BenGardiner wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #5227 +/- ##
==========================================
- Coverage 79.25% 78.02% -1.24%
==========================================
Files 394 376 -18
Lines 98742 98354 -388
==========================================
- Hits 78261 76739 -1522
- Misses 20481 21615 +1134
🚀 New features to boost your workflow:
|
BenGardiner
force-pushed
the
fix-windows-select-objects-races
branch
from
October 14, 2026 14:13
309b276 to
f70b6ed
Compare
Contributor
Author
|
😔 |
…ze TLS test timeouts In scapy/automaton.py, select_objects() on Windows handles objects with negative file descriptors (such as PcapReader) by appending them directly to results and omitting them from events. When WaitForMultipleObjects returns an event index, looking up inputs[res] was offset by any preceding negative-fileno objects, resulting in incorrect return sets. Map events to input objects explicitly via events_to_inputs. In test/scapy/layers/tls/tlsclientserver.uts, increase the server accept and client handshake request timeouts in test_tls_client_native from 1s to 5s to avoid intermittent timeouts on CPU-throttled Windows CI runners. In test/windows.uts, add unit test coverage for select_objects when inputs contain negative file descriptor objects. AI-Assisted: yes (GPT-5.6-Cyber)
BenGardiner
force-pushed
the
fix-windows-select-objects-races
branch
from
October 18, 2026 23:35
f70b6ed to
8c52a29
Compare
Contributor
Author
|
Closing in favor of #5234, which incorporates these changes alongside upstream CI test fixes. This message was written with the help of AI (GPT-5.6-Cyber). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
scapy/automaton.py,select_objects()on Windows handles objects with negative file descriptors by appending them directly toresultsand omitting them fromevents. WhenWaitForMultipleObjectsreturns an event index, looking upinputs[res]was offset byany preceding negative-fileno objects, resulting in incorrect return sets. Map
eventsto input objects explicitly viaevents_to_inputs.test/scapy/layers/tls/tlsclientserver.uts, increase the handshake request timeout intest_tls_client_nativefrom 1s to 5s to avoid intermittent timeouts on CPU-throttled Windows CI runners.test/windows.uts, add unit test coverage forselect_objectswhen inputs contain negative file descriptor objects.with the assistance of AI: Yes
AI-Assisted: yes (Gemini 3.8 Flash)
fixes: intermittent test failures in the windows-latest 3.14 root -K scanner CI job on upstream Scapy master