Repository navigation
test: tolerate graphed's positional-session deprecation - #1787
Merged
ariostas merged 1 commit intoOct 28, 2026
Merged
Conversation
graphed 0.0.10 makes session= an optional keyword on its readers and warns on the positional Session form. Under filterwarnings = ["error"] the two tests that call from_awkward(Session, ...) positionally would fail; the positional form is the only one graphed 0.0.9 accepts, so they keep it and ignore that one warning. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Author
|
@ariostas this one is pretty simple - may I go ahead and merge it? (it's to not fail on some deprecation warnings that are coming in graphed 0.0.10). |
Contributor
Author
|
@ariostas ping over here - this one is blocking moving forward with a PR on the graphed side (just to make sure uproot doesn't break when we go to 0.0.10. |
ariostas
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
graphed 0.0.10 deprecates passing a Session positionally to its array-less readers (
from_awkward(session, ...)→from_awkward(..., session=session)). uproot'sfilterwarnings = ["error"]turns thatDeprecationWarninginto a failure in two tests that call such a reader positionally:tests/test_1720_graphed_read.py::test_head_requires_one_uproot_sourcetests/test_1720_graphed_write.py::test_refusals_happen_before_anything_is_writtenEach gets
@pytest.mark.filterwarnings("ignore:.*is deprecated; pass session=:DeprecationWarning"). The marker is inert on graphed 0.0.9, so this can merge now.DeprecationWarning: from_awkward(session, ...) is deprecated; pass session= as a keyword