[rnathuji]

Jira: SHRMP-340. Follow-up to #76 (SHRMP-339).

What and why

checkForAWSErroredJobs() only garbage-collected orphan ECS task definitions on its success paths. If getAllTasksWithJobId or describeECSTasks rejected, the function threw before cleanup ran, and orphan task definitions were left behind for that poll cycle.

The lookup and per-task reporting now live in a private reportErroredTasks() helper. checkForAWSErroredJobs() runs cleanup on both paths:

• Lookup fails: cleanup still runs, best-effort. Any cleanup error is logged with console.error, and the original error is rethrown so createResilientCycle logs the real cause.
• Lookup succeeds: unchanged. Cleanup runs once, and a cleanup failure still propagates as before.

Missing env vars (ECS_CLUSTER, MANAGEMENT_APP_*) still fail before any AWS calls, and no cleanup runs. Cleanup needs the management app tag, so it can't run without them.

Reviewer focus

• Catch-and-rethrow rather than finally. A plain finally { await cleanupTaskDefs(...) } would let a cleanup error replace the lookup error, which would hide the root cause. The .catch keeps cleanup best-effort on the failure path only.
• The early return for "no tasks" no longer calls cleanup itself. Cleanup now happens once in the caller.

Testing

• pnpm run checks passes (typecheck, Prettier, ESLint).
• pnpm test passes: 162 tests, 100% coverage, including src/lib/aws-check-jobs.ts.
• New tests in aws-check-jobs.test.ts:
  • getAllTasksWithJobId rejects: same error rethrown, cleanup runs, describeECSTasks not called
  • describeECSTasks rejects: same error rethrown, cleanup runs
  • lookup and cleanup both reject: the original lookup error wins, and the cleanup error is logged
  • lookup succeeds and cleanup rejects: the cleanup error propagates (unchanged behaviour)
  • a required env var is missing: rejects with no lookup and no cleanup calls
  • the early-return test now asserts cleanup runs exactly once
• Not run locally: the Trivy and SonarQube CI steps. They will run on this PR.

No merge preconditions or manual steps.

🤖 Generated with Claude Code

[chrisbendel]

Looks good - checked that running cleanup on the failure path can't delete anything extra, since orphan status only depends on the BMA ready list and not on the report step.