Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions declared through a function typedef can panic during method code generation or static-wrapper serialization. Virtual methods can instead be emitted without their required
thisargument. For example,typedef int F(int); struct S { F take; };panics, andvirtual F take;produces an incorrect callable signature.Resolve typedef/elaborated declaration types to their canonical function type before parsing the signature at the original function cursor. Ordinary function declarations keep their existing path. Added header coverage for instance/static/virtual/free functions, distinct receiver types and an alias chain, plus a C static-wrapper regression.
Fixes #3486.
Validation on main f08d4ff:
Additional validation on the same PR commit:
objc_template). A fresh isolated build of unchanged main fails that test with the identical generated-output diff. The earlier focused typedef checks included the normal round-trip checks.Ready for maintainer review. The native E2E evidence above is from macOS arm64; the upstream matrix supplies the additional platform validation.
Prepared with OpenAI Codex assistance; no independent human review is claimed.