Repository navigation
[CI Fix][ROCm] Refresh DeepSeek V3 CP MI350X golden - #5557
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
acisseJZhong
marked this pull request as ready for review
October 20, 2026 05:16
acisseJZhong
requested review from
fegin,
tianyu-l,
wconstab and
wwwjn
as code owners
October 20, 2026 05:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
#4760 switched DeepSeek V3 context parallelism to the compact MLA path and refreshed the A10G golden, but the MI350X golden was not updated. The ROCm workflow only runs after changes reach main, so the stale accelerator-specific file first surfaced there.
The new sequence is bitwise identical across consecutive main runs, including:
The first passing run before #4760 and the first failing run used the same ROCm image digest and PyTorch nightly, isolating the change to TorchTitan source. The same new sequence also persists across later dependency nightlies.
Test plan
SKIP=pyrefly-check pre-commit run --all-files(pass)pre-commit run --all-files: all other hooks pass; local Pyrefly is blocked because the shared venv has PyTorch 2.14 and older torch_checkpointing APIs while current main targets PyTorch 2.16 nightly APIs.