Repository navigation
Fix pytest.approx regression with JAX arrays - #15285
Merged
Merged
Conversation
pyba-chronographer
Bot
added
the
bot:chronographer:provided
Backport to 9.2.x: 💚 backport PR created✅ Backport PR branch: Backported as #15301 🤖 @patchback |
bluetech
added a commit
that referenced
this pull request
Oct 30, 2026
Fix `pytest.approx` regression with JAX arrays (cherry picked from commit 4b3bb3c)
bluetech
added a commit
that referenced
this pull request
Oct 30, 2026
…b3bb3cca4bb53ffe38473b7f29d832d42a4177b/pr-15285 [PR #15285/4b3bb3cc backport][9.2.x] Fix `pytest.approx` regression with JAX arrays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #15284.
For simplicity, I've decided to just catch the
NotImplementedErrorraised byjax.Arraywhen trying to access.flat; other implementations are possible but they would change the logic/heuristic for other types too.