Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a guest opened a route that needs a user (e.g. a user-only app or an IdP route), the guest session was ended or marked as expired, so the guest lost access to their shares and was sent to the login.
Now the guest session is kept and the guest is redirected to their shares instead:
How Has This Been Tested?
setupAuthGuardredirects user/IdP/app routes to the guest shares for an active guest contextsetupAuthGuardrenews an expired or unavailable guest session into the guest sharessetupAuthGuardfalls back to the login without a guest session or without the guest shares routeauthServicerestores instead of expiring the guest session on routes that need a user, and clears it once a user is signed in