Repository navigation
fix: show all invite search results returned by the server - #4081
Merged
Merged
Conversation
JammingBen
force-pushed
the
fix/invite-search-results
branch
from
October 30, 2026 12:22
e8d1863 to
7d70e06
Compare
kulmann
approved these changes
Oct 30, 2026
| } | ||
|
|
||
| const selectShareRoleType = async (shareRoleType: ShareRoleType) => { | ||
| const selectShareRoleType = (shareRoleType: ShareRoleType) => { |
Member
There was a problem hiding this comment.
any consumer that called this with await? I only see removed async in the diff, no removed await.
Member
Author
There was a problem hiding this comment.
Only the @click handler of the button calls it, no await there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The invite search (share sidebar and "Add members" when creating a space) filtered the server's results again on the client. It only kept recipients whose
displayNameormailcontained the search term. The server also matches on fields it doesn't return, e.g.onPremisesSamAccountName, and$searchresponses can lackmail. So valid results were dropped and the list showed "No users or groups found."The server already filters by the term, so the client-side filter is removed and the list shows what the server returns.
Without the client filter, results from an older search could show up under a newer term, or be picked with Enter while the list was closed. Each new search now cancels the pending (debounced) and the running request. Switching the share type goes through the same path, so it clears the list and shows the spinner as well.
How to test
OC_SHOW_USER_EMAIL_IN_RESULTStofalseRelated Issue
mailfield, breaking the space/file member-invite autocomplete #4039