Repository navigation
fix(sharesstorageprovider): reject a share deleted by its mount point - #917
Merged
Merged
Conversation
A DELETE of /Shares/<name> reaches the sharesstorageprovider relative to the share jail root, e.g. './<name>'. Only a reference by share id with the path '.' rejected the share, so this one was forwarded to the owner's storage and deleted the shared resource itself. Since #916 that is denied with 403.
v-scharf
force-pushed
the
fix/delete-share-root-by-path
branch
from
October 26, 2026 17:09
91f8794 to
b72c529
Compare
Member
aduffeck
approved these changes
Oct 27, 2026
github-project-automation
Bot
moved this from Qualification
to Done
in OpenCloud Team Board
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a received share by its mount point (
DELETE /Shares/<name>) was forwarded to the owner's storage instead of rejecting the share, and is denied with 403 since #916.Failing test: https://ci.opencloud.rocks/repos/3/pipeline/4690/355