Repository navigation
[Fix #1774] Update schema to latest specification version - #1817
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The new run.script.stdin field is accepted but silently ignored during execution, so scripts configured to consume it never receive the input.
1 open issue
What changed in this PR
Updates the SDK’s bundled workflow schema to specification version 1.0.4, aligning it with upstream changes for issue #1774.
Changes:
- Updates the schema identifier from 1.0.3 to 1.0.4.
- Adds the script
stdinproperty. - Refines URI patterns to distinguish literal URIs from URI templates.
| File | Description |
|---|---|
types/src/main/resources/schema/workflow.yaml |
Updates the schema version, script input definition, and URI validation patterns. |
Review effort: Balanced
ricardozanini
left a comment
There was a problem hiding this comment.
Hold until we release 1.1.0 please!
You mean not merging this one till specfication 1.1.0 is not released? |
There was a problem hiding this comment.
🟡 Changes recommended
Subprocess execution can still deadlock because output draining starts only after waiting for exit, and reader tasks share an executor with workers blocked on their completion.
2 open issues
2 resolved since last review
Review effort: Balanced
…ication version Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
There was a problem hiding this comment.
🟡 Changes recommended
Detached shell commands with await: false hit an UnsupportedOperationException in an ignored background future because output collection does not handle null return types.
1 open issue
1 resolved since last review
Review effort: Balanced
There was a problem hiding this comment.
🟡 Changes recommended
Non-awaited scripts can exhaust JVM heap through unbounded output collection and monopolize executor workers by waiting for background processes, potentially blocking unrelated workflows.
2 open issues
1 resolved since last review
Review effort: Balanced
…ollection for await false Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
There was a problem hiding this comment.
🔵 Needs a closer look
The required Build & Verify and Lint (Spotless + Checkstyle) CI results are unavailable and cannot be verified with the available tools, so review must wait until both checks are confirmed green.
No open issues 🎉
2 resolved since last review
Review effort: Balanced
There was a problem hiding this comment.
🔵 Needs a closer look
Review must wait until the required Build & Verify and Lint (Spotless + Checkstyle) CI checks are confirmed green, as their results were not provided and cannot be verified with the available tools.
No open issues 🎉
Review effort: Balanced


Fix #1774