Skip to content

[Fix #1774] Update schema to latest specification version - #1817

Merged
fjtirado merged 3 commits into
open-workflow-specification:mainfrom
fjtirado:Fix_#1774
Nov 17, 2026
Merged

fjtirado merged 3 commits into
open-workflow-specification:mainfrom
fjtirado:Fix_#1774

Conversation

@fjtirado

@fjtirado fjtirado commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

Fix #1774

Copilot AI balanced review requested due to automatic review settings November 3, 2026 10:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new run.script.stdin field is accepted but silently ignored during execution, so scripts configured to consume it never receive the input.

1 open issue
What changed in this PR

Updates the SDK’s bundled workflow schema to specification version 1.0.4, aligning it with upstream changes for issue #1774.

Changes:

  • Updates the schema identifier from 1.0.3 to 1.0.4.
  • Adds the script stdin property.
  • Refines URI patterns to distinguish literal URIs from URI templates.
File Description
types/​src/​main/​resources/​schema/​workflow.yaml Updates the schema version, script input definition, and URI validation patterns.

Review effort: Balanced

@fjtirado
fjtirado marked this pull request as draft November 3, 2026 10:28
@fjtirado
fjtirado marked this pull request as ready for review November 6, 2026 17:21
Copilot AI balanced review requested due to automatic review settings November 6, 2026 17:21
@fjtirado
fjtirado marked this pull request as draft November 6, 2026 17:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Critical issues remain: Python stdin writes can deadlock streaming scripts, and JavaScript scripts cannot read the configured stdin.

2 open issues
1 resolved since last review

Review effort: Balanced

@fjtirado
fjtirado marked this pull request as ready for review November 10, 2026 12:41
Copilot AI balanced review requested due to automatic review settings November 10, 2026 12:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Synchronous stdin writes without concurrent stdout/stderr draining can deadlock Python scripts on large payloads, preventing workflow completion.

1 open issue
1 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 10, 2026 12:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Python runner can deadlock by writing stdin before draining process output and incorrectly fail successful scripts that close stdin early.

2 open issues

Review effort: Balanced

@fjtirado
fjtirado marked this pull request as draft November 10, 2026 13:54

@ricardozanini ricardozanini left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold until we release 1.1.0 please!

@fjtirado

fjtirado commented Nov 10, 2026 •

Copy link
Copy Markdown
Collaborator Author

Hold until we release 1.1.0 please!

You mean not merging this one till specfication 1.1.0 is not released?
Yes, thats the idea. But even if merged, there is not need to sync, we can always incorporate further changes.

@fjtirado
fjtirado marked this pull request as ready for review November 10, 2026 15:10
Copilot AI balanced review requested due to automatic review settings November 10, 2026 15:10

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Subprocess execution can still deadlock because output draining starts only after waiting for exit, and reader tasks share an executor with workers blocked on their completion.

2 open issues
2 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 10, 2026 15:24

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Output readers start only after stdin is written and the process exits, leaving a reproducible deadlock when stdout or stderr fills its pipe buffer.

1 open issue
1 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 10, 2026 19:40

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the workflow schema update and script/shell stdin support.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

…ication version

Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 11:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Non-awaited shell commands still buffer stdout until exit, allowing a continuously logging background process to exhaust the SDK JVM's heap.

1 open issue

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 16, 2026 13:47

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Detached shell commands with await: false hit an UnsupportedOperationException in an ignored background future because output collection does not handle null return types.

1 open issue
1 resolved since last review

Review effort: Balanced

Copilot AI balanced review requested due to automatic review settings November 16, 2026 14:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Non-awaited scripts can exhaust JVM heap through unbounded output collection and monopolize executor workers by waiting for background processes, potentially blocking unrelated workflows.

2 open issues
1 resolved since last review

Review effort: Balanced

…ollection for await false

Signed-off-by: Francisco Javier Tirado Sarti <ftirados@ibm.com>
Copilot AI balanced review requested due to automatic review settings November 16, 2026 14:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The required Build & Verify and Lint (Spotless + Checkstyle) CI results are unavailable and cannot be verified with the available tools, so review must wait until both checks are confirmed green.

No open issues 🎉

2 resolved since last review

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Review must wait until the required Build & Verify and Lint (Spotless + Checkstyle) CI checks are confirmed green, as their results are unavailable.

No open issues 🎉

Review effort: Balanced

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Review must wait until the required Build & Verify and Lint (Spotless + Checkstyle) CI checks are confirmed green, as their results were not provided and cannot be verified with the available tools.

No open issues 🎉

Review effort: Balanced

@fjtirado
fjtirado merged commit 0ae53e7 into open-workflow-specification:main Nov 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to latest version of openworkflow specification schema

3 participants