Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .github/workflows/R-CMD-check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,25 @@ jobs:
run: tar -tf src/rust/vendor.tar.xz >/dev/null

- uses: r-lib/actions/check-r-package@465b7d8e732ca3921382b1674c59bada9cbf3399
if: runner.os != 'macOS'
with:
error-on: '"warning"'

- name: Check macOS with Rust absent from PATH (CRAN configuration)
if: runner.os == 'macOS'
shell: bash
run: |
set -euo pipefail
rust_free_path="$(printf '%s\n' "$PATH" | tr ':' '\n' | while IFS= read -r dir; do
if [ ! -x "$dir/cargo" ] && [ ! -x "$dir/rustc" ]; then printf '%s:' "$dir"; fi
done)"
export PATH="${rust_free_path%:}"
if command -v cargo || command -v rustc; then
echo "Rust must be absent from PATH for this regression check" >&2
exit 1
fi
Rscript -e 'rcmdcheck::rcmdcheck(args = c("--as-cran", "--no-manual"), error_on = "warning")'

R-CMD-check-no-ort:
name: ubuntu-latest (no ORT, R ${{ matrix.r }}, offline)
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: churon
Title: 'ONNX Runtime' Integration
Version: 0.1.12
Version: 0.1.13
Authors@R: c(
person(given = "Chanyub", family = "Park", role = c("aut", "cre"),
email = "mrchypark@gmail.com",
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# churon 0.1.13

* Fix source installation when Rust is installed in `~/.cargo/bin` but is not
on `PATH`, as on the CRAN macOS builders. Rust version requirements continue
to be checked by `configure`.
37 changes: 10 additions & 27 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,37 +1,20 @@
## Resubmission (0.1.12)
## Update (0.1.13)

This resubmission addresses the CRAN review of version 0.1.11:
This update fixes the installation failures reported by the CRAN macOS
release/oldrel checks and the additional M1mac check for version 0.1.12.

* Removed the redundant "for R" from the title and quoted software names
consistently; MNIST is no longer quoted.
* Added ONNX Runtime and GitHub release URLs to DESCRIPTION.
* Documented the return types and meaning of `$.TensorInfo` results.
* Replaced non-running placeholder examples with executable examples using
the bundled MNIST model, conditional on runtime availability.
* Removed software installation calls from the installer examples.
* Required an explicit `destdir` for runtime installation. The installer no
longer writes into the package library, and configures `ORT_DYLIB_PATH`
for the current session. Later-session configuration is documented.
* Removed automatic R package installation from the development setup script.
`configure` successfully finds Cargo and rustc under `~/.cargo/bin`, but the
Makevars recipe ran a redundant `rustc --version` before adding that directory
to PATH. On the CRAN builders this failed with `rustc: No such file or directory`.

## Local validation (2026-09-11)

* macOS arm64, R 4.5.2, Rust 1.97.1.
* Runtime-enabled tests: 90 passed, no failures, warnings, or skips.
* Offline `R CMD check --as-cran --no-manual`: 0 errors, 0 warnings, 1 note.
The note reports that current time could not be verified with network access
disabled. The official Debian `checkbashisms` utility was supplied for this check.
Package installation, documentation, examples, and tests passed.
* Removed the redundant version commands from the Unix and Windows Makevars.
`configure` continues to enforce Cargo and rustc >= 1.88.0.
* Applied the existing Unix Cargo PATH fallback to the Windows build as well.
* Added a macOS CI regression check with Cargo and rustc removed from PATH.

## Additional notes

Rust dependencies are vendored in the source package for offline builds.
ONNX Runtime is not bundled. The dedicated installer downloads it only on
explicit request with a user-supplied destination. Tests requiring a runtime
are skipped when it is absent; tests do not download or install software.

## Submission status

Version 0.1.12 was uploaded and submitted through the CRAN web form on
2026-09-11 (upload ID 354755). The maintainer subsequently confirmed publication on CRAN.
The Git repository is being synchronized with the published 0.1.12 release.
3 changes: 0 additions & 3 deletions src/Makevars
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ CARGOTMP = $(CURDIR)/.cargo
VENDOR_FLAGS =

$(STATLIB):
# Check rustc version
rustc --version

# Vendor setup: extract vendored crates and configure cargo
if [ -f ./rust/vendor.tar.xz ]; then \
tar -xf ./rust/vendor.tar.xz -C $(CURDIR) && \
Expand Down
4 changes: 1 addition & 3 deletions src/Makevars.win
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,6 @@ $(SHLIB): $(STATLIB)
CARGOTMP = $(CURDIR)/.cargo

$(STATLIB):
# Check rustc version
rustc --version

# Vendor setup: extract vendored crates and configure cargo
if [ -f ./rust/vendor.tar.xz ]; then \
tar -xf ./rust/vendor.tar.xz -C $(CURDIR) && \
Expand All @@ -42,6 +39,7 @@ $(STATLIB):
if [ "$(NOT_CRAN)" != "true" ]; then \
export CARGO_HOME=$(CARGOTMP); \
fi && \
export PATH="$(PATH):$(HOME)/.cargo/bin" && \
export CARGO_TARGET_X86_64_PC_WINDOWS_GNU_LINKER="$(CARGO_LINKER)" && \
export LIBRARY_PATH="${LIBRARY_PATH};$(CURDIR)/$(TARGET_DIR)/libgcc_mock" && \
if [ -f "ort_config.env" ]; then . ./ort_config.env; fi && \
Expand Down
Loading