Repository navigation
chore(local-env): default to mock-authorities 47b7994 - #2406
Open
justinfrevert wants to merge 3 commits into
Open
justinfrevert wants to merge 3 commits into
justinfrevert wants to merge 3 commits into
Conversation
Bump the pinned mock-authorities image in local-environment and the fork-network workflow default from f6cbf91 to 8e7f81d, the newest published build. It builds the fork block through the runtime (midnight-node-ops#110) and adds `convert --fork-at`; every flag local-env passes to `convert` is unchanged. Assisted-by: AI <noreply@ai-assistant> Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
Assisted-by: AI <noreply@ai-assistant> Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
Move the pin from 8e7f81d to 47b7994, built from midnight-node-ops#127. Older images open node 2.x databases with parity-db 0.4, cannot see a long chain's grandpa_voters, and leave GRANDPA on the snapshot's authority set, so the fork never finalizes. Assisted-by: AI <noreply@ai-assistant> Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
local-environmentpins mock-authoritiesf6cbf91(2026-09-08). This PR moves the local-env default and thefork-networkworkflow default to47b7994, built from shieldedtech/midnight-node-ops#127. That image:grandpa_voters(66,810 bytes on the current Preview snapshot) and leave GRANDPA on the snapshot's authority set. Blocks are produced, but finality stays at the fork block. Details are in midnight-node-ops#127.convert --fork-at.convert's default fork point (the finalized tip) is unchanged, and this PR does not pass--fork-at. The image defaults to--db-format current, which matches every network today; node 1.x snapshots need--db-format legacy.47b7994is built from the #127 branch, not main. If #127 changes before it merges, this pin moves with it.🗹 TODO before merging
📌 Submission Checklist
git commit -s) for the DCO🧪 Testing Evidence
Local Preview fork from this branch with the default image (no
MOCK_AUTHORITIES_IMAGEoverride): latest Preview snapshot (block 30564,v2.1.101),NODE_IMAGE=ghcr.io/midnightntwrk/midnight-node:2.1.101,--num-validators 3.grandpa_roundState)f6cbf91(current main default)8e7f81d47b7994(this PR)47b7994pulls and runs on an arm64 Mac. The publish workflow was fixed in Toolkit: Update to new compactc version #127 to push a plain manifest again; its first build,50351ed, was an OCI index that Docker on arm64 refuses to pull.prettier/eslintpass onmockAuthorities.ts, andactionlintpasses onfork-network.yml.Unrelated regression found while testing
#2366 (Renovate, Nov 6) moved the
minimatchoverride inlocal-environment/package.jsonfrom10.2.4to11.0.1.glob@11.1.0requiresminimatch@^10.1.1, and with 11.x every wildcard pattern matches nothing. As a result,run,stop,image-upgradeandverify-finalityfail for every well-known network (No .network.yaml file found for namespace '<net>'), andforkManifest.test.tsfails. The runs above used a local, uncommitted10.2.4override. The proper fix belongs in a separate PR.🔱 Fork Strategy
🤖 Generated with Claude Code