Skip to content

chore(local-env): default to mock-authorities 47b7994 - #2406

Open
justinfrevert wants to merge 3 commits into
mainfrom
chore/local-env-bump-mock-authorities
Open

justinfrevert wants to merge 3 commits into
mainfrom
chore/local-env-bump-mock-authorities

Conversation

@justinfrevert

@justinfrevert justinfrevert commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Overview

local-environment pins mock-authorities f6cbf91 (2026-09-08). This PR moves the local-env default and the fork-network workflow default to 47b7994, built from shieldedtech/midnight-node-ops#127. That image:

  • Makes forks of long-lived node 2.x snapshots finalize. Older images open the node's parity-db 0.5 database with parity-db 0.4. They cannot see a long chain's grandpa_voters (66,810 bytes on the current Preview snapshot) and leave GRANDPA on the snapshot's authority set. Blocks are produced, but finality stays at the fork block. Details are in midnight-node-ops#127.
  • Builds the fork block through the runtime (midnight-node-ops#110) and adds convert --fork-at.

convert's default fork point (the finalized tip) is unchanged, and this PR does not pass --fork-at. The image defaults to --db-format current, which matches every network today; node 1.x snapshots need --db-format legacy.

47b7994 is built from the #127 branch, not main. If #127 changes before it merges, this pin moves with it.

🗹 TODO before merging

  • Ready
  • shieldedtech/midnight-node-ops#127 merged (repin if its final image differs)

📌 Submission Checklist

  • All commits are signed off (git commit -s) for the DCO
  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Local Preview fork from this branch with the default image (no MOCK_AUTHORITIES_IMAGE override): latest Preview snapshot (block 30564, v2.1.101), NODE_IMAGE=ghcr.io/midnightntwrk/midnight-node:2.1.101, --num-validators 3.

image GRANDPA set (grandpa_roundState) finality
f6cbf91 (current main default) 5546, weight 6 (snapshot's set) stuck at fork block #30563
8e7f81d 5546, weight 6 stuck at #30563
47b7994 (this PR) 5547, weight 3 (converted set) follows best ~2 blocks behind (#30565 → #30577 in 75 s)
  • 47b7994 pulls and runs on an arm64 Mac. The publish workflow was fixed in Toolkit: Update to new compactc version #127 to push a plain manifest again; its first build, 50351ed, was an OCI index that Docker on arm64 refuses to pull.
  • prettier/eslint pass on mockAuthorities.ts, and actionlint passes on fork-network.yml.

Unrelated regression found while testing

#2366 (Renovate, Nov 6) moved the minimatch override in local-environment/package.json from 10.2.4 to 11.0.1. glob@11.1.0 requires minimatch@^10.1.1, and with 11.x every wildcard pattern matches nothing. As a result, run, stop, image-upgrade and verify-finality fail for every well-known network (No .network.yaml file found for namespace '<net>'), and forkManifest.test.ts fails. The runs above used a local, uncommitted 10.2.4 override. The proper fix belongs in a separate PR.

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other: local-environment tooling and a manual CI workflow default only
  • N/A

🤖 Generated with Claude Code

Bump the pinned mock-authorities image in local-environment and the
fork-network workflow default from f6cbf91 to 8e7f81d, the newest
published build. It builds the fork block through the runtime
(midnight-node-ops#110) and adds `convert --fork-at`; every flag
local-env passes to `convert` is unchanged.

Assisted-by: AI <noreply@ai-assistant>
Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
@justinfrevert justinfrevert added the bot:ai-assisted Authored or substantially edited by an AI agent label Nov 9, 2026
@justinfrevert
justinfrevert requested review from a team as code owners November 9, 2026 23:00
Assisted-by: AI <noreply@ai-assistant>
Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
Move the pin from 8e7f81d to 47b7994, built from
midnight-node-ops#127. Older images open node 2.x databases with
parity-db 0.4, cannot see a long chain's grandpa_voters, and leave
GRANDPA on the snapshot's authority set, so the fork never finalizes.

Assisted-by: AI <noreply@ai-assistant>
Signed-off-by: Justin Frevert <justinfrevert@gmail.com>
@justinfrevert justinfrevert changed the title chore(local-env): default to mock-authorities 8e7f81d chore(local-env): default to mock-authorities 47b7994 Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:ai-assisted Authored or substantially edited by an AI agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant