Skip to content

[POC][multi-vector] Add MinMax MaxSim benchmark - #1509

Draft
juchen-ms (partychen) wants to merge 2 commits into
microsoft:mainfrom
partychen:minmax-benchmark
Draft

juchen-ms (partychen) wants to merge 2 commits into
microsoft:mainfrom
partychen:minmax-benchmark

Conversation

@partychen

Copy link
Copy Markdown
Contributor
  • Does this PR have a descriptive title that could go in our release notes?
  • Does this PR add any new dependencies?
  • Does this PR modify any existing APIs?
  • Is the change to the API backwards compatible?
  • Should this result in any changes to our documentation, either updating existing docs or adding new ones?

Reference Issues/PRs

What does this implement/fix? Briefly explain your changes.

Any other comments?

Integrate the merged MinMax matrix kernel with an owned-query factory, runtime ISA selection, an independent scalar reference, and shared construction errors. Preserve QueryMatRef inputs and add focused factory and query-cloning coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 94d30f43-fadc-4a6b-889b-406de424a1ab
@partychen juchen-ms (partychen) changed the title Minmax benchmark [multi-vector] Add MinMax MaxSim benchmark Oct 23, 2026
@partychen juchen-ms (partychen) changed the title [multi-vector] Add MinMax MaxSim benchmark [POC][multi-vector] Add MinMax MaxSim benchmark Oct 23, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.71245% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.20%. Comparing base (8a9ff2d) to head (cb89267).

Files with missing lines Patch % Lines
diskann-benchmark/src/multi_vector/minmax.rs 97.91% 3 Missing ⚠️
diskann-quantization/src/minmax/multi/factory.rs 99.00% 3 Missing ⚠️
diskann-benchmark/src/multi_vector/kernels.rs 90.47% 2 Missing ⚠️
diskann-benchmark/src/inputs/multi_vector.rs 97.91% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1509      +/-   ##
==========================================
+ Coverage   92.16%   92.20%   +0.04%     
==========================================
  Files         592      597       +5     
  Lines      123582   124252     +670     
==========================================
+ Hits       113901   114569     +668     
- Misses       9681     9683       +2     
Flag Coverage Δ
miri 92.20% <98.71%> (+0.04%) ⬆️
unittests 92.15% <98.70%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
diskann-benchmark/src/main.rs 94.23% <100.00%> (+0.16%) ⬆️
diskann-benchmark/src/multi_vector/driver.rs 88.23% <100.00%> (-0.29%) ⬇️
diskann-benchmark/src/multi_vector/mod.rs 100.00% <100.00%> (ø)
..._kernels/maxsim/packed_minmax_x_unpacked_minmax.rs 98.18% <100.00%> (ø)
diskann-quantization/src/minmax/multi/kernel.rs 100.00% <100.00%> (ø)
diskann-quantization/src/minmax/multi/meta.rs 100.00% <100.00%> (ø)
diskann-quantization/src/minmax/multi/prepared.rs 100.00% <100.00%> (ø)
diskann-quantization/src/minmax/multi/reference.rs 100.00% <100.00%> (ø)
...-quantization/src/multi_vector/distance/factory.rs 77.51% <ø> (ø)
diskann-benchmark/src/inputs/multi_vector.rs 76.85% <97.91%> (+22.75%) ⬆️
... and 3 more

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants