[williammartin]

Description

Hihi, thanks for creating an extension for the GitHub CLI. I'm a maintainer for gh. We were doing some work on short lived tokens and I noticed you are depending on the api package from the cli/cli module. Historically, the maintainers did a bad job of setting expectations around importing packages from this module. I'm strongly considering biting the bullet and moving packages into internal to reduce our ongoing maintenance burden, but I'd prefer not to just break everyone.

This PR removes the dependency on github.com/cli/cli/v2/api (and pkg/httpmock) in favour of github.com/cli/go-gh/v2's api.RESTClient, which we do expect to follow semantic versioning.

pkg/iostreams and pkg/cmdutil are still imported from cli/cli. Replacing iostreams means copying in a lot of terminal handling code, so I've left it out to keep this PR small. If anything, it indicates an opportunity to create new abstractions in go-gh.

Run/workflow types

The upstream run/shared fetch helpers (GetRun, GetJobs, GetAnnotations, etc.) all take the cli/cli api.Client, so they're replaced with small go-gh equivalents in runs.go.

I also redefined the handful of types and render helpers this extension uses instead of importing them from run/shared and workflow/shared: Run, Job, Step, Annotation, RenderJobs, RenderAnnotations and Symbol. Upstream shared.Run keeps the workflow name in an unexported field that only cli/cli's own GetRun can populate. Reusing it would render an empty workflow name in the run header.

Behaviour change: per-host auth

Previously the HTTP client was built for the default host (GH_HOST, the sole logged-in host, or github.com), while the request URL was derived from the --repo host. go-gh only attaches the Authorization header when the request host matches the client's host, so -R ghes.example.com/o/r was sent unauthenticated.

The client is now built with Host: repo.RepoHost(), so the target host's token is used. I haven't exercised this against a GHES instance.

Scenario (default = github.com)	Before	After
-R o/r / -R github.com/o/r	github.com token	same
-R ghes.example.com/o/r, logged in to GHES	unauthenticated	GHES token ✅
-R ghes.example.com/o/r, not logged in to GHES	unauthenticated	error: authentication token not found for host ghes.example.com

Relatedly, the current user's login (used to find the dispatched run) now comes from REST GET /user instead of GraphQL.

Test Change

Since I wanted to drop httpmock usage, I swapped it for the httptest package. A smaller change would have been a simple replacement transport stubber but honestly, I think httptest is just a better black box approach. Can back it out if you feel differently! The expected output in the tests is unchanged.

Caveat

Copilot did most of the work here so I can't say I've given it extreme scrutiny but I did guide it along the way and it looks generally correct to me.

Demo

These GIFs were recorded on github.com with a build from this PR, against a scratch repo containing copies of this repo's Hello and Goodbye workflows. I also recorded the failure scenario with a build of main, and its output matched, including exit code 1.

gh dispatch workflow, success:

gh dispatch repository, success:

gh dispatch workflow, failure:

Two things in these recordings are pre-existing on main and unchanged here:

• Annotations don't show up in the watch view, because jobs that are still queued get cached with no annotations.
• Failed runs print Error: SilentError.