Repository navigation
chatinfo: don't refetch missing bots on every message - #139
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production logs show a steady stream of
Failed to get info to update ghostwithbots.inforeturningbot_not_found: about 700 per hour across 46 logins and 76 bot IDs, with single bots failing 50-100 times an hour. Each one is abot_messageor its edit.AggressiveUpdateInfomakes every message callGetUserInfo, which is gated only byLastSync.LastSyncis set inwrapUserInfo'sExtraUpdates, so it never moves whenbots.infofails, and each message from a bot that Slack can't find for this workspace repeats the request on the portal event loop.This treats
bot_not_foundas an answer: the ghost is marked as a bot andLastSyncis bumped, so the lookup is retried afterMinGhostSyncIntervalinstead of on every message. Name and avatar are left unchanged.Tag
@indentto continue the conversation here.