Skip to content

federation/client: Allow RespSendJoin fields to be omitted #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timedoutuk merged 2 commits into from
Oct 27, 2026
Merged

federation/client: Allow RespSendJoin fields to be omitted #648

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
db39ad6
federation/client: Allow RespSendJoin fields to be omitted
timedoutuk Oct 26, 2026
7d1cde3
omitzero for MembersOmitted
timedoutuk Oct 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions federation/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ type ReqMakeJoin struct {
}

type RespMakeJoin struct {
RoomVersion id.RoomVersion `json:"room_version"`
RoomVersion id.RoomVersion `json:"room_version,omitempty"`
Event PDU `json:"event"`
}

Expand All @@ -325,9 +325,9 @@ type ReqSendKnock struct {

type RespSendJoin struct {
AuthChain []PDU `json:"auth_chain"`
Event PDU `json:"event"`
MembersOmitted bool `json:"members_omitted"`
ServersInRoom []string `json:"servers_in_room"`
Event PDU `json:"event,omitempty"`
MembersOmitted bool `json:"members_omitted,omitzero"`
ServersInRoom []string `json:"servers_in_room,omitempty"`
State []PDU `json:"state"`
}

Expand Down
Loading