Repository navigation
bridgev2/database: expose incoming-message anchors and KV errors - #601
Conversation
tulir
left a comment
There was a problem hiding this comment.
Looks fine, but what's GetLastNonFakePartAtOrBeforeTimeExcludingSender needed for 🤔
(also, the kv store technically isn't meant for critical parts that would need to handle errors, but I guess it is the easiest option in some cases)
its to choose the initial recovery anchor, it will be used in twitter dms. There can be an outgoing message stored after an incoming that were missed by the bridge, so using the newest stored message would start catch-up too late. This will allow us to select the latest incoming message by excluding the current user |
1d625ff to
6c57850
Compare
|
No issues found.
All required CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
Checklist