Skip to content

bridgev2/database: expose incoming-message anchors and KV errors - #601

Merged
highesttt merged 1 commit into
mainfrom
highest/message-anchor-exclude-sender
Oct 26, 2026
Merged

highesttt merged 1 commit into
mainfrom
highest/message-anchor-exclude-sender

Conversation

@highesttt

Copy link
Copy Markdown
Contributor

Checklist

@highesttt
highesttt marked this pull request as ready for review October 8, 2026 19:41
@Fizzadar
Fizzadar requested a review from tulir October 9, 2026 15:05
@tulir tulir changed the title database: expose incoming-message anchors and KV errors bridgev2/database: expose incoming-message anchors and KV errors Oct 9, 2026

@tulir tulir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but what's GetLastNonFakePartAtOrBeforeTimeExcludingSender needed for 🤔

(also, the kv store technically isn't meant for critical parts that would need to handle errors, but I guess it is the easiest option in some cases)

@highesttt

Copy link
Copy Markdown
Contributor Author

Looks fine, but what's GetLastNonFakePartAtOrBeforeTimeExcludingSender needed for 🤔

(also, the kv store technically isn't meant for critical parts that would need to handle errors, but I guess it is the easiest option in some cases)

its to choose the initial recovery anchor, it will be used in twitter dms. There can be an outgoing message stored after an incoming that were missed by the bridge, so using the newest stored message would start catch-up too late. This will allow us to select the latest incoming message by excluding the current user

@highesttt
highesttt force-pushed the highest/message-anchor-exclude-sender branch from 1d625ff to 6c57850 Compare October 26, 2026 16:23
@indent

indent Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Issues

No issues found.

CI Checks

All required CI checks passed on 6c57850.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)
  • Indent Review Agent · No bugs found in this PR.
Full results

Indent Review Agent

  • Summary: No bugs found in this PR.
  • Last ran on commit: 6c578504
  • Latest result
    {
      "summary": "No bugs found in this PR.",
      "findings": []
    }

@highesttt
highesttt merged commit ae411b4 into main Oct 26, 2026
11 checks passed
@highesttt
highesttt deleted the highest/message-anchor-exclude-sender branch October 26, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants