Repository navigation
fix: report compile errors in the shape bundlers print - #318
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 26451cf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Vite and Rolldown print `id:line:column` and `frame` around a plain `message`, but a Marko compile error carries its position and code frame in `message` (with non-enumerable `loc`/`frame` that Vite's SSR runner drops), so builds printed `undefined:undefined` and the frame twice. An error in the transformed template is rebuilt with a plain message, a flat `loc` and `frame`; an error from a template it analyzed keeps only its message, since Rolldown reports every transform error against the transformed id. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
DylanPiercey
force-pushed
the
dpiercey-ws-agent-feedback-wejtdz
branch
from
September 23, 2026 20:54
3683ddb to
26451cf
Compare
Merged
This was referenced Sep 23, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vite and Rolldown print a plugin error as
id:line:column, thenmessage, thenframe. A MarkoCompileErrorinstead carries its position and code frame insidemessage, with a Babel-shaped, non-enumerableloc/frame, so builds printedundefined:undefinedand the frame twice, and Vite's SSR module runner droppedloc/frameentirely in dev.Compile errors are now rebuilt at the transform boundary. An error in the template being transformed gets a plain message (its label), a flat
locandframe, all enumerable so they survive the SSR runner. An error from another template compiled during this one's analysis keeps only the compiler's own message, which names that file: Rolldown always reports transform errors against the transformed id, so a position there would point at the wrong file. Aggregates and errors from compilers before 5.42.6 (noCompileError.filename) pass through unchanged; the dev dependency moves to 5.42.6.The fixture harness gains an
errormode that snapshots what Vite prints in dev (throughbuildErrorMessage) and what Rolldown reports on build, with fixtures for an error in the template, in a tag it uses, several errors at once, and an SSR template.🤖 Generated with Claude Code