Skip to content

fix: report compile errors in the shape bundlers print - #318

Merged
DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-agent-feedback-wejtdz
Sep 23, 2026
Merged

DylanPiercey merged 1 commit into
mainfrom
dpiercey-ws-agent-feedback-wejtdz

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

Vite and Rolldown print a plugin error as id:line:column, then message, then frame. A Marko CompileError instead carries its position and code frame inside message, with a Babel-shaped, non-enumerable loc/frame, so builds printed undefined:undefined and the frame twice, and Vite's SSR module runner dropped loc/frame entirely in dev.

Compile errors are now rebuilt at the transform boundary. An error in the template being transformed gets a plain message (its label), a flat loc and frame, all enumerable so they survive the SSR runner. An error from another template compiled during this one's analysis keeps only the compiler's own message, which names that file: Rolldown always reports transform errors against the transformed id, so a position there would point at the wrong file. Aggregates and errors from compilers before 5.42.6 (no CompileError.filename) pass through unchanged; the dev dependency moves to 5.42.6.

The fixture harness gains an error mode that snapshots what Vite prints in dev (through buildErrorMessage) and what Rolldown reports on build, with fixtures for an error in the template, in a tag it uses, several errors at once, and an SSR template.

🤖 Generated with Claude Code

@changeset-bot

changeset-bot Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 26451cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Vite and Rolldown print `id:line:column` and `frame` around a plain
`message`, but a Marko compile error carries its position and code frame in
`message` (with non-enumerable `loc`/`frame` that Vite's SSR runner drops),
so builds printed `undefined:undefined` and the frame twice. An error in the
transformed template is rebuilt with a plain message, a flat `loc` and
`frame`; an error from a template it analyzed keeps only its message, since
Rolldown reports every transform error against the transformed id.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@DylanPiercey
DylanPiercey force-pushed the dpiercey-ws-agent-feedback-wejtdz branch from 3683ddb to 26451cf Compare September 23, 2026 20:54
@DylanPiercey
DylanPiercey merged commit 5956ab7 into main Sep 23, 2026
7 checks passed
@github-actions github-actions Bot mentioned this pull request Sep 23, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Roadmap Oct 2, 2026
@DylanPiercey DylanPiercey self-assigned this Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant