Skip to content

Rename the persisted option to patches - #315

Closed
DylanPiercey wants to merge 4 commits into
mainfrom
dpiercey-ws-persisted-pages-xh8764
Closed

DylanPiercey wants to merge 4 commits into
mainfrom
dpiercey-ws-persisted-pages-xh8764

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

The persisted plugin option becomes patches, passed through to the compiler under the same name. Changeset updated.

🤖 Generated with Claude Code

DylanPiercey and others added 4 commits September 8, 2026 11:32
Compiles templates for pages that persist across navigations (patched in
place). Passed through to the compiler as a plain option.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@changeset-bot

changeset-bot Bot commented Sep 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 57bfbc8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DylanPiercey

Copy link
Copy Markdown
Contributor Author

Closing for now; the vite side lands after marko.

@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: b7ef48f9-7b2b-4179-9ad4-3b3b9dab0251

📥 Commits

Reviewing files that changed from the base of the PR and between 8a58d61 and 57bfbc8.

📒 Files selected for processing (2)
  • .changeset/patches-option.md
  • src/index.ts

Walkthrough

The PR adds an optional patches setting to @marko/vite options and the augmented compiler configuration type. The setting is passed into the compiler’s base configuration. A changeset records a patch release and documents patch-protocol compilation for in-place page updates across navigations.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch dpiercey-ws-persisted-pages-xh8764

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant