You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Both PALU training scripts default to an unpopulated reference-log directory, causing evaluation to fail before training begins under the documented setup.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
A tokenizer-inserted terminal EOS remains masked in answer-containing examples, omitting its preservation loss instead of receiving the expected -200 label.
No open issues 🎉
1 previously missed issue
In code that hasn't changed since last review
Unmask existing terminal EOS when answer tokens are present
src/data/palu.py:117
When a fast tokenizer inserts a terminal EOS with (0, 0) offsets, the label loop assigns it -100, and this branch leaves it masked because EOS is already present. Its prediction therefore receives no preservation loss, unlike an explicitly appended EOS. Set an existing terminal EOS label to -200 when answer tokens are present, including at max_length, while leaving prompt-only truncated examples masked.
1. Mark terminal EOS as non-sensitive when answer tokens are present, including at max_length.
2. Keep prompt-only examples masked and add regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds the implementation of the ACL 2026 paper PALU (2601.03190, nxZhai/PALU) to Open-Unlearning.
Before submitting