Repository navigation
debian: packaging improvements from the Debian package - #25
Merged
Merged
Conversation
dh_girepository only computes ${gir:Depends} for packages shipping
GObject introspection data (.gir/.typelib files). python3-xapp ships
only Python modules and does not use ${gir:Depends}, so the addon is a
no-op.
gobject-introspection was added to Build-Depends only to provide the gir
dh sequence (linuxmint#21), so it can go together with the addon.
Assisted-by: Claude Code:claude-opus-5-5
Build-depend on dh-sequence-python3 instead of dh-python and drop --with=python3 from debian/rules. Assisted-by: Claude Code:claude-opus-5-5
po/meson.build uses i18n.gettext(), which needs msgfmt to build the translations. It was pulled in only indirectly through debhelper. Assisted-by: Claude Code:claude-opus-5-5
The modules import Gio, GLib and GObject (gir1.2-glib-2.0), Gtk and Gdk (gir1.2-gtk-3.0), Pango (gir1.2-pango-1.0) and XApp (gir1.2-xapp-1.0) through python3-gi, but none of them was declared in Depends. Assisted-by: Claude Code:claude-opus-5-5
X-Python-Version refers to Python 2, whose support was removed, and X-Python3-Version >= 3.0 does not restrict anything. Assisted-by: Claude Code:claude-opus-5-5
None of the v13 changes affects this package: there are no tests, overrides, manpages or tmpfiles, and dh_missing already reported no uninstalled files, so its new --fail-missing default is harmless. The contents and control files of the built .deb are unchanged. Assisted-by: Claude Code:claude-opus-5-5
Import debian/copyright from the Debian packaging: it uses the DEP-5 machine-readable format, lists copyright years and holders and includes the full LGPL-2+ license notice. Adapt it to upstream: point Source to the current repository name and extend the Linux Mint copyright on debian/* to 2026. Assisted-by: Claude Code:claude-opus-5-5
4.7.0 is the debian-policy version available in Ubuntu 24.04 (noble), the oldest base still supported. Assisted-by: Claude Code:claude-opus-5-5
Assisted-by: Claude Code:claude-opus-5-5
AUTHORS, README and TODO are empty files, which dh_installdocs skips, so the file installs nothing. Assisted-by: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings to the upstream
debian/the fixes and cleanups already done in the Debian package of python-xapp, keeping compatibility with Mint 22 / Ubuntu 24.04 (noble) as the oldest supported base. Each change is a separate commit:girdh addon and thegobject-introspectionbuild-dep:dh_girepositoryonly computes${gir:Depends}for packages shipping.gir/.typelibfiles, python3-xapp ships none and does not use that substvar (the build-dep had been added only to provide the addon, build failing for with dpkg-buildpackage #21)dh-sequence-python3gettextto Build-Depends (needed byi18n.gettext()inpo/meson.build, until now pulled in only indirectly through debhelper)gir1.2-glib-2.0,gir1.2-gtk-3.0,gir1.2-pango-1.0,gir1.2-xapp-1.0andpython3-giX-Python-Version/X-Python3-Versionfieldsdebian/copyrightto the DEP-5 machine-readable formatHomepagefielddebian/python3-xapp.docs:AUTHORS,READMEandTODOare empty, sodh_installdocsskips them and the file installs nothingWhy the runtime dependencies matter
The currently published package (3.0.2 in zena) depends only on
python3:anyandpython3-psutil. On a system without PyGObject already installed, the module cannot even be imported:Testing
All done in a Linux Mint 22.3 (zena) chroot:
.debunchanged (file list and control files identical).debbuilt from current master, the installed files are the same exceptusr/share/doc/python3-xapp/copyright; in the control data, besides the newDependsandHomepage, droppingX-Python3-Versiononly removes the no-op(>= 3.0~)frompython3:anyand-V 3.0-from thepy3compile/pypy3compilecalls in postinst.debpulls in everything needed and all modules import fine (xapp,xapp.os,xapp.threading,xapp.util,xapp.SettingsWidgets,xapp.GSettingsWidgets,xapp.widgets.ListEditor,xapp.widgets.Dialog)Notes outside the packaging (not changed in this PR)
xapp/SettingsWidgets.pyis committed with the executable bit (mode 100755) although it is only an imported module, so lintian reportsexecutable-in-usr-lib. It also has a#!/usr/bin/python3shebang, like the other modules that are not executable.meson.builddeclaresmeson_version : '>=0.47.0', but meson warns that the/operator on strings (used forpodir) needs 0.49.0. The Build-Depends keepmeson (>= 0.47.0)as declared by the project; the minimum inmeson.buildshould probably be raised.