Repository navigation
Conversation
| msgid "Include people for all items for each list request" | ||
| msgstr "Include people for all items for each list request" |
There was a problem hiding this comment.
This change of wording really doesn't make sense, imo, and it will cause extra work of updating all the translations. I don't see any reason to change it like this.
I'd actually be in favor of removing the setting (or at least making it invisible for now in case we change our minds later), or if we are going to change it, then make the wording more like "Enable lazy loading for people" or "Load people in background." That way it would be more descriptive and easier for the layperson to understand.
There was a problem hiding this comment.
On my setup , I did not find any reason to keep old behavior.
If you are in favor of hiding/disabling it , I'll change it.
There was a problem hiding this comment.
Reverted the text back to original
| include_people = settings.getSetting('include_people') == "false" | ||
| # Start the info dialog monitor (lazy load data when the info dialog is opened) | ||
| if include_people: |
There was a problem hiding this comment.
This is arguably the most confusing way possible to write this check, and I spent several minutes trying to figure out why it wasn't behaving as expected before I realized that the setting value and check value are inverted.
There was a problem hiding this comment.
Removed the code , if settings is hidden no need for this condition check.
Addressing #455
Technically we can remove "Include people" settings and always do lazy load , since it is much faster, but some users might want to keep old behavior and wont like the side effect of info dialog is updating on the fly.
So i appended the settings text to include more information.
As mentioned on the issue, I used LLM at start for inspiration/feasibility check but re-tuned and checked the code later on.