Repository navigation
refactor(themes): align recipe keys, interface files and prop arrays - #31671
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
changed the title
thetaPC
marked this pull request as ready for review
October 29, 2026 22:20
Co-authored-by: OS-jacobbell <228905018+OS-jacobbell@users.noreply.github.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
Migrated components follow different conventions:
lineHeight,minHeight), while others nest under a shared CSS prefix (min: { height }).ion-titlenestsletter: { spacing }, even though no other CSS property starts withletter-.badge.interfaces.ts), while newer ones are singular (title.interface.ts).ion-chipandion-spinnerdeclare their prop unions inline, so their tests hardcode the values.What is the new behavior?
line.heightandmin.heightinion-chip,min.heightinion-item-divider, andline.heightinion-skeleton-text.letter.spacinginion-titletoletterSpacing, matchingion-badgeandion-chip.themes.interfaces.tsstays plural.ION_CHIP_FILLS,ION_CHIP_SIZES,ION_CHIP_SHAPESandION_SPINNER_SIZES. The chip, spinner and tab-button badge tests now loop over these and theION_BADGE_*arrays.Does this introduce a breaking change?
These recipes and file names haven't been released yet.