Repository navigation
Conversation
thetaPC
added this pull request to stack #31629
October 23, 2026 22:23
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
1 of 2 tasks
1 of 2 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
ios buttons use values carried over from v9 instead of iOS 17: 13px and 20px labels at the small and large sizes, medium weight, larger icons pushed into the padding, a 0.5 fade when disabled, and spinners at their own 28px size, which makes buttons taller.
What is the new behavior?
ios buttons follow iOS 17, from the Apple Design Resources kit and measurements of a native
UIButton:1.2emwith a 4px gap to the label, at the padding edgePressed outline buttons in ios toolbars fill with the toolbar color again. The migration ported a
nextrule that never matched (::slotted(*) .button-outline), which left the label white on a transparent background.Toolbar buttons keep their previous colors when disabled.
Snapshots are in #31646.
Does this introduce a breaking change?
The
iosbutton follows iOS 17 for its font, icons, spinners and disabled state. To keep a previous value, set the token for global styles, or the matching--ion-button-*CSS variable for component-specific styles. Replace<fill>withsolid,outlineorclear, and<size>withsmall,mediumorlarge. Values inemare relative to the font size, so reverting the font size also needs the previousemvalues.13px,16pxand20px15px,15pxand17pxIonButton.size.<size>.font.size500400IonButton.hue.bold.<fill>.default.font.weight0.77em,0.875emand1em0.6667em,0.9333emand1.1765em(same pixels at the new font size)IonButton.size.<size>.padding.startand.end2.16em,2.125emand2.5em1.8667em,2.2667emand2.9412em(same pixels at the new font size)IonButton.size.<size>.min.height1.35em1.2emIonButton.size.<size>.icon.font.size0.3eminto the padding and a0.3emgap0.2222emgap (4pxat the default size)IonButton.size.<size>.icon.leading.marginand.trailing.margin1.308125em,1.125emand0.9em1.1333em,1.2emand1.0588em(same pixels at the new font size)IonButton.size.<size>.iconOnly.icon.font.size28pxby default)1.2emby default (18pxat the default size), with the other spinner sizes in their usual ratio to itIonButton.size.<size>.spinner.size.<spinner size>.widthand.height0.5opacity25%, which outline also uses for its border, and on solid, an8%containerIonButton.hue.bold.<fill>.disabled.opacity,.color,.backgroundand.border.colorOther information
Not matched to iOS 17 on purpose
soft(6px), which feat(button): set default shape to soft for ios and round for md and ionic themes #29404 set from SwiftUI0. WebKit already applies SF Pro tracking to the system fontLeft for the parents
ion-buttonsmigrationHow to test