Skip to content

Verification Request: homebridge-samsung-local #1381

Open

Description

@Abdulazizruh

Plugin Name

homebridge-samsung-local

Link To GitHub Repo

https://github.com/Abdulazizruh/homebridge-samsung-local

Plugin Icon (Optional)

No response

The plugin does not offer the same nor less functionality than that of any existing verified plugin.

🟢 Yes

The plugin successfully installs and does not start unless it is configured.

🟢 Yes

The plugin does not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.

🟢 Yes

The plugin does not contain any analytics or calls that enable you to track the user.

🟢 Yes

If the plugin needs to write files to disk (cache, keys, etc.), it stores them inside the Homebridge storage directory.

🟢 Yes

The plugin does not throw unhandled exceptions, the plugin must catch and log its own errors.

🟢 Yes

More Information

What it does

Local, cloud-free control of Samsung SmartThings-compatible appliances over the LAN (OCF, CoAP over DTLS). No SmartThings API token or subscription, no Home Assistant, no MQTT.

How it differs from the verified SmartThings plugins

The verified homebridge-smartthings-oauth talks to the SmartThings cloud API. This plugin talks to the appliance directly on the local network and keeps working without internet access. The HomeKit layout for air conditioners (thermostat, fan, optional-mode switches, display light, humidity) deliberately follows the same idea, and the two plugins run side by side.

Things reviewers will want to know

  • The protocol layer is the MIT-licensed Python library smartthings-local, used unmodified. The plugin starts a small Python helper as a child process and stops it on shutdown.
  • There is no post-install script. On first start (or from the settings page) the plugin creates a private virtual environment at <homebridge storage>/samsung-local/venv and installs pinned packages from PyPI into it. No root, nothing installed system-wide. It needs Python 3.11+ with venv, which the official Homebridge Docker image (Ubuntu 24.04) already includes. If Python is missing or too old, the plugin logs a clear message and does nothing else.
  • Everything it writes (virtual environment, client certificate, cached readings) is under <homebridge storage>/samsung-local. The settings page has a confirmed "delete data" action limited to that folder.
  • No analytics or tracking. The only outbound connection is the one-time package download from PyPI.
  • Custom settings UI (@homebridge/plugin-ui-utils), English and Arabic: add an appliance by IP address, test and discover, choose what appears in HomeKit, download redacted diagnostics.
  • CI runs the test suite on Node 22, 24 and 26.

Current scope, stated plainly

  • Air conditioners get a full HomeKit accessory. So far this is confirmed on one real unit (ARTIK051_PRAC_20K, Homebridge in Docker on a Raspberry Pi); the resource map is ported from the MIT-licensed LocalThings project.
  • Other appliance types connect for diagnostics only and create no accessories yet. Samsung TVs are not supported.
  • 64-bit ARM and x86-64 only (prebuilt Python wheels).

The plugin is not affiliated with Samsung.

Activity

  1. github-actions commented on Nov 21, 2026

    @github-actions
    Contributor

    🔴 Failed Checks

    • Package JSON: keywords must include at least one of 'supports-hap' or 'supports-matter' — see Declaring Supported Transports
    • GitHub Repo: version mismatch - NPM has v0.1.0-beta.3 but GitHub package.json has v1.0.0
    • Config Schema JSON: schema is invalid - required should not be a boolean property on individual fields. In JSON Schema, required must be an array at the object level listing required property names. Remove "required": true/false from individual properties and use "required": ["property1", "property2"] at the object level instead.

    🟢 Passed Checks

    • Installation: successfully installed
    • Package JSON: homepage exists
    • Package JSON: bugs.url exists and seems a valid URL
    • Package JSON: keywords exist and contain 'homebridge-plugin'
    • Package JSON: 'preinstall' in scripts is not present
    • Package JSON: 'install' in scripts is not present
    • Package JSON: 'postinstall' in scripts is not present
    • Package JSON: engines.node property is compatible with Node 22
    • Package JSON: engines.node property is compatible with Node 24
    • Package JSON: engines.homebridge property is compatible with Homebridge 2.5.0
    • Package JSON: initializer function found
    • NPM Package: has not been deprecated
    • Config Schema JSON: exists and is valid JSON
    • Config Schema JSON: contains a valid pluginAlias
    • Config Schema JSON: pluginAlias matches the platform/accessory registered in code
    • Config Schema JSON: the pluginType is set to 'platform'
    • Config Schema JSON: contains a name schema property
    • Dependencies: homebridge is not declared as a runtime/peer/bundled dependency
    • Dependencies: hap-nodejs is not declared as a runtime/peer/bundled dependency
    • Security: no known vulnerabilities in dependencies
    • Security: code patterns flagged for manual review
    • Security: no privilege escalation attempts detected
    • GitHub Repo: repository is public
    • GitHub Repo: repository is not archived
    • GitHub Repo: issues are enabled
    • GitHub Repo: contains releases

    🔍 For Manual Review

    The following items were detected and require manual review. We understand that these items may be false positives.

    • Security: accesses environment files in src/runtime/helperClient.js

    ℹ️ Check Details

    • These checks were run against v0.1.0-beta.3 of the plugin.
    • Link to the run workflow: visit →.

    📋 Next Steps

    • Once you have fixed these failures, comment /check on this issue to run the checks again — your request will not move forward until the checks are re-run.
    • If updating your package.json and config.schema.json files, don't forget to publish a new version to NPM.
    • Remember this is an automatic script: if you think something has been marked as a failure in error, let us know with a reply.
    • Feel free to ask any questions you have by replying to this issue.
  2. added
    awaiting-changesuse after review has started - awaiting user to make changes to plugin
    and removed
    pendingthe label given to a new verification/icon request
    on Nov 21, 2026
  3. Abdulazizruh commented on Nov 22, 2026

    @Abdulazizruh
    Author

    All three failed checks are fixed in v1.0.8, which is now on npm and matches the GitHub package.json: (1) supports-hap added to keywords; (2) in config.schema.json, required moved to object-level arrays; (3) npm and GitHub versions are in sync.

    On the manual-review item: src/runtime/helperClient.js does not read any environment file. It passes process.env plus one variable (the plugin's own credentials folder inside the Homebridge storage directory) to the Python helper it spawns.

    Plugin icon (512x512 PNG): https://raw.githubusercontent.com/Abdulazizruh/homebridge-samsung-local/main/assets/icon.png

  4. Abdulazizruh commented on Nov 22, 2026

    @Abdulazizruh
    Author

    /check

  5. added
    pendingthe label given to a new verification/icon request
    and removed
    awaiting-changesuse after review has started - awaiting user to make changes to plugin
    on Nov 22, 2026
  6. github-actions commented on Nov 22, 2026

    @github-actions
    Contributor

    🟢 Passed Checks

    • Installation: successfully installed
    • Package JSON: homepage exists
    • Package JSON: bugs.url exists and seems a valid URL
    • Package JSON: keywords exist and contain 'homebridge-plugin'
    • Package JSON: keywords declare the supported transports ('supports-hap' and/or 'supports-matter')
    • Package JSON: 'preinstall' in scripts is not present
    • Package JSON: 'install' in scripts is not present
    • Package JSON: 'postinstall' in scripts is not present
    • Package JSON: engines.node property is compatible with Node 22
    • Package JSON: engines.node property is compatible with Node 24
    • Package JSON: engines.homebridge property is compatible with Homebridge 2.5.0
    • Package JSON: initializer function found
    • NPM Package: has not been deprecated
    • GitHub Repo: version in package.json (v1.0.8) matches NPM version (v1.0.8)
    • Config Schema JSON: exists and is valid JSON
    • Config Schema JSON: contains valid JSON Schema
    • Config Schema JSON: schema has valid type property
    • Config Schema JSON: schema has valid properties for object type
    • Config Schema JSON: contains a valid pluginAlias
    • Config Schema JSON: pluginAlias matches the platform/accessory registered in code
    • Config Schema JSON: the pluginType is set to 'platform'
    • Config Schema JSON: contains a name schema property
    • Dependencies: homebridge is not declared as a runtime/peer/bundled dependency
    • Dependencies: hap-nodejs is not declared as a runtime/peer/bundled dependency
    • Security: no known vulnerabilities in dependencies
    • Security: code patterns flagged for manual review
    • Security: no privilege escalation attempts detected
    • Runtime: homebridge installed successfully
    • Runtime: no config - homebridge should start without plugin configuration and plugin should not load
    • Runtime: platform only - plugin should start with just platform property
    • Runtime: minimal required - plugin should start with minimal required configuration
    • Runtime: full config - plugin should start with comprehensive configuration
    • Runtime: plugin shuts down cleanly within 12s of SIGTERM
    • Runtime: plugin restarts cleanly without port conflicts
    • GitHub Repo: repository is public
    • GitHub Repo: repository is not archived
    • GitHub Repo: issues are enabled
    • GitHub Repo: contains releases

    🔍 For Manual Review

    The following items were detected and require manual review. We understand that these items may be false positives.

    • Security: accesses environment files in src/runtime/helperClient.js

    ℹ️ Check Details

    • These checks were run against v1.0.8 of the plugin.
    • Link to the run workflow: visit →.

    📋 Next Steps

    All checks passed successfully, nice work! Your plugin and/or icon will now be manually reviewed by the Homebridge team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions