Repository navigation
Skip header parsing when set_locale gets a single locale - #147
Merged
Merged
Conversation
set_locale parses its argument as an Accept-Language header (gsub, split, a regexp sub per entry, sort) even when it is a single locale like :ja or "zh_TW", which is what it gets almost every time: with gettext_i18n_rails every I18n.locale= and I18n.with_locale (twice: set and restore) calls it, often many times per page (links to each language, hreflang tags). A single locale already in the de / de_DE form parses to itself, so use it directly. Per locale= call: 24 -> 5 allocations, 2.85 -> 1.44 µs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set_locale parses its argument as an Accept-Language header (gsub, split, a regexp sub per entry, sort) even when it is a single locale like :ja or "zh_TW", which is what it gets almost every time: with gettext_i18n_rails every I18n.locale= and I18n.with_locale (twice: set and restore) calls it, often many times per page (links to each language, hreflang tags).
A single locale already in the de / de_DE form parses to itself, so use it directly. Per locale= call: 24 -> 5 allocations, 2.85 -> 1.44 µs.