Repository navigation
Conversation
Meorge
force-pushed
the
feat/code-actions-signal-stub
branch
from
October 14, 2026 04:33
80ebbc2 to
b8a9c69
Compare
Open
1 of 2 tasks
Meorge
force-pushed
the
feat/code-actions-signal-stub
branch
2 times, most recently
from
October 15, 2026 19:27
ce3c1fe to
46c093d
Compare
Contributor
Author
|
Tests have been added! |
Meorge
force-pushed
the
feat/code-actions-signal-stub
branch
from
October 17, 2026 04:46
46c093d to
bae13fc
Compare
Meorge
marked this pull request as ready for review
October 17, 2026 04:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem(s) does this PR solve?
textDocument/codeActionfor generating method stubs for missing functions godot-proposals#14307 (but does not close it completely)Additional information
Note
This PR is dependent on #121338 being merged first. It looks like the branch, and thus the PR itself, include #121338's commits in it so this could technically be merged on its own and it would supersede #121338. But I think it would be better to merge #121338 on its own first, then have these changes reviewed and merged separately.
This PR adds a "Quick Fix" code action, which detects when a non-existent function name is provided to a
Signal.connect()call, and creates a function stub with the signal's signature below the current function.Godot.-.CA.Signal.Stub.mp4
To Do
signal some_name(...)up above in the file)extends SomeOtherClass)gdscript_analyzer.cppintopush_error(), perhaps by adding a "code action hint" optional parameter topush_error()