Repository navigation
Fix adding decision options from natural Chat requests - #701
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An explicit request such as “add these options to the decision” was rejected when it followed discussion in the same Chat message. Chopin then wrote a table beside the card instead of adding selectable options.
Recognise trailing imperative requests and resolve “the decision” only when one editable open choice card is eligible. Preserve named targeting and reject ambiguous, quoted, hypothetical, withdrawn or deferred instructions. Context introduced by a colon keeps its scope across later clauses and paragraphs; unexplained prose after a directive cancels the request. Clarify that append-only tool calls omit
title; decision records and document projections still commit together without selecting an answer.Validation on source commit
1b9eaac30(final headc904a2f22adds only lane memory): 60 focused tests, including the exact reported request, persisted four-option card, and conditional/example scope regressions; full TypeScript checks andbun run ci. Independently reviewed. All final-head GitHub checks pass, including browser and container jobs.The earlier broad macOS suite had 16 failures: 15 reproduced on unchanged
main; one passed in isolation on both branches. It was not rerun for this narrow follow-up. The downloaded final-head browser report records 863 integration tests passing immediately, one responsive content-swap test passing on retry, and six skipped. Design and diagram suites have no retries or failures. The responsive case also flaked on the unchanged base.