Repository navigation
feat: move Device Spoof into the tweak catalog as a staged tweak - #75
Merged
Merged
Conversation
Replace the hidden product-type tweak and the standalone DeviceSpoofing tool page with a single catalog tile that behaves 1:1 like the Device Artwork Subtype tweak: tap toggles it, the wheel picker expands inline under its row, and the full identity blast is written through the shared staged apply flow. - Picker options derive from DeviceSpoofingManager.targets so the list never drifts; index 0 keeps the real identity. - GestaltStore.apply routes the devicespoof tweak to DeviceSpoofingManager after the generic pass (its write-set spans ~20 CacheExtra keys plus ArtworkDevice entries that plain modifications cannot express) and runs before any disk write, so manager failures abort loudly. - New tweak id avoids mis-mapping stale persisted picker indices from the old 11-option ProductType picker. - Remove DeviceSpoofingView and dead manager helpers (changedKeyCount, currentTarget, realMachineIdentifier, verify, clearDeviceNames).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DeviceSpoofingManager.targetsso they can never drift; index 0 ("None (Real Identity)") is a no-op.GestaltStore.applyroutes this tweak toDeviceSpoofingManager.applyafter the generic modification pass (the full identity blast spans ~20 CacheExtra keys plus ArtworkDevice entries and name keys that must not be invented), before any disk write - manager failures abort loudly with the pristine backup intact.devicespoof) so stale persisted indices from the old 11-option ProductType picker cannot mis-map onto the new target list.DeviceSpoofingView, the orphanedapplyDeviceSpoof(), and dead manager helpers (changedKeyCount,currentTarget,realMachineIdentifier,verify,clearDeviceNames). Net -245 lines.Test plan