Skip to content

[RFC-0014] auth: move to cryptov1 - #1334

Open
matheuscscp wants to merge 1 commit into
rfc-0014-overhaul-v2from
rfc-0014-auth-crypto
Open

matheuscscp wants to merge 1 commit into
rfc-0014-overhaul-v2from
rfc-0014-auth-crypto

Conversation

@matheuscscp

@matheuscscp matheuscscp commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Part of: fluxcd/flux2#6103

As a consequence of moving to cryptov1, this PR introduces additional behaviors that did not exist before:

  • Awareness to the annotations that overlap with existing spec fields and/or controller flags.
  • Various config validations, e.g. custom audiences (from kubeconfig ConfigMap) never worked when the local cluster is GKE, so now we capture the error earlier and make it prettier.
  • Splitting audiences by commas. As mentioned in the RFC, this a deliberate hardening choice to avoid common vulnerabilities.
  • Credential expiration for KSA tokens from the new annotation.

I'm also adding support in runtime/features to define "retired" feature gates. The controller will now print a log if a retired gate is being used, telling the user that it no longer has any affect and why. This will be used later in Flux 2.11 to retire the gate ObjectLevelWorkloadIdentity, as the feature will become GA and always enabled. Using it will always be opt-in via .spec.serviceAccountName or --default*-service-account + a provider that supports it.

No new service X provider combination is being introduced yet, e.g. no SPIFFE support, no KSA token support for generic registry, etc.

One more hardening I found along the way: all our calls to TokenRequest API now prevent the token from being created with the local cluster's API audiences. All our tokens are for access to external services, not the local Kubernetes cluster.

@matheuscscp matheuscscp added enhancement New feature or request area/security Security related issues and pull requests area/rfc RFC related issues and pull requests labels Oct 16, 2026
Comment thread apis/meta/reference_types.go Outdated
@matheuscscp
matheuscscp marked this pull request as ready for review October 16, 2026 17:30
@matheuscscp
matheuscscp requested a review from a team as a code owner October 16, 2026 17:30
@matheuscscp
matheuscscp marked this pull request as draft October 17, 2026 12:27
@matheuscscp
matheuscscp changed the base branch from main to rfc-0014-overhaul-v2 October 17, 2026 15:56
@matheuscscp
matheuscscp added this pull request to stack #1336 October 17, 2026 15:57
@matheuscscp
matheuscscp force-pushed the rfc-0014-auth-crypto branch 4 times, most recently from 52b82b2 to d5f5d26 Compare October 17, 2026 20:07
@matheuscscp
matheuscscp force-pushed the rfc-0014-auth-crypto branch 2 times, most recently from 5784a54 to be387f5 Compare October 17, 2026 21:15
@matheuscscp
matheuscscp force-pushed the rfc-0014-auth-crypto branch 2 times, most recently from ed0a1d1 to a6e981f Compare October 17, 2026 21:44
@matheuscscp
matheuscscp force-pushed the rfc-0014-auth-crypto branch 2 times, most recently from b5c915f to 1a531f2 Compare October 19, 2026 10:43
@matheuscscp
matheuscscp force-pushed the rfc-0014-auth-crypto branch 2 times, most recently from 97a1ebf to 341cc77 Compare October 19, 2026 13:57
@matheuscscp
matheuscscp force-pushed the rfc-0014-auth-crypto branch 2 times, most recently from 039300e to 771a1d1 Compare October 19, 2026 15:09
@matheuscscp
matheuscscp force-pushed the rfc-0014-auth-crypto branch 2 times, most recently from 6796316 to 6639e9b Compare October 19, 2026 23:35
Signed-off-by: Matheus Pimenta <matheuscscp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/rfc RFC related issues and pull requests area/security Security related issues and pull requests enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants