Repository navigation
build(deps-dev): pin supertest to 7.3.0 - #774
Closed
UlisesGascon wants to merge 1 commit into
Closed
UlisesGascon wants to merge 1 commit into
UlisesGascon wants to merge 1 commit into
Conversation
supertest 7.3.1 regresses streaming requests (.write()/.pipe()) built from an app factory: the ephemeral server URL is resolved too late, so the request fires against 127.0.0.1 with no port and gets ECONNREFUSED. The chunked/inflate/limit tests use streaming, so they fail on 7.3.1 while non-streaming tests pass. Pin to 7.3.0 until it is fixed upstream. Ref: forwardemail/supertest#911
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
Author
|
Duplicated. see #773. @saadkhantareen was faster! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supertest@7.3.1breaks the test suite. Its #907 change resolves the ephemeral server URL too late, but superagent builds streaming requests (.write()/.pipe()) eagerly, so they fire against127.0.0.1with no port and getECONNREFUSED. Our chunked / inflate / limit tests use the streaming API, so they fail on 7.3.1; non-streaming tests pass. 7.3.0 is clean.Pin
supertestto7.3.0until the upstream regression is fixed.Upstream issue: forwardemail/supertest#911