Repository navigation
Conversation
Post the branch, PR, UTC time and run link to the NOTIFICATION_WEBHOOK secret when any step of the mirror job fails. A missing secret or an unreachable webhook only logs a warning. (cherry picked from commit 26688e8)
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the snapshot-mirroring failure notification change.
No open issues 🎉
What changed in this PR
Adds failure notifications to the release/3.6 snapshot mirroring workflow so CDN update failures no longer go unnoticed.
Changes:
- Sends the base branch, merged PR, UTC timestamp, and workflow run link to
NOTIFICATION_WEBHOOKafter a job failure. - Passes values through environment variables and builds the JSON payload with
jq. - Adds bounded webhook retries and logs warnings if the secret is missing or delivery fails.
| File | Description |
|---|---|
.github/workflows/mirror.yml |
Adds a failure-triggered webhook notification before housekeeping. |
Review effort: Balanced
lystopad
deleted the
feature/lystopad/mirror-failure-notification-release-3.6
branch
November 18, 2026 13:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "Notify about failure" step to the Mirror workflow. When any step of the mirror job fails, it posts the base branch, the merged PR, the UTC time and the run link to the
NOTIFICATION_WEBHOOKsecret:Mirror runs failed silently from 2026-11-16 to 2026-11-18 (the rclone config in
MIRROR_CONFlost itstypeline), so the CDN served old tomls without anyone noticing.envand the JSON is built withjq, so branch or PR text cannot break the script or the payload.mirror.ymlruns from the PR's base branch, so the same change goes tomain,release/3.6,release/3.10andrelease/3.4in separate PRs.Tested locally: the YAML parses; the step's script against a local HTTP listener sends the expected JSON, warns without failing when the secret is empty or the webhook returns 500, and passes shell/JSON special characters in the branch name through as plain text.