Repository navigation
Update the last response timestamp in the HTTP client LIFO connection selector - #6479
Open
adityaanikam wants to merge 1 commit into
Open
adityaanikam wants to merge 1 commit into
adityaanikam wants to merge 1 commit into
Conversation
… selector Assisted-by: Anthropic Claude (claude-sonnet-5-5) Signed-off-by: adityaanikam <adityanikam9502@gmail.com>
vietj
force-pushed
the
fix-6474-lifo-selector
branch
from
November 2, 2026 19:57
bbd1623 to
9d3a2b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6474
LIFO_SELECTORnever assignedlast, so it compared every connection against 0 and returned the last connection in list order instead of the one that received a response most recently. This is the first option from the issue:lastis now updated whenever a connection is selected.testPoolLIFOPolicyonly passes because the responses arrive in list order, so I addedtestPoolLIFOPolicyWithResponsesInReverseOrder, where the first connection created is the most recently used. It fails without the change.Http1xTest#testPoolLIFOPolicy*,HttpPoolCapacityTestandHttp1xProxyTestpass.