Repository navigation
Conversation
Resetting or cancelling an HttpClientRequest before anything was written did not close the stream on HTTP/2 and HTTP/3, so the connection lease was never recycled. Each such request permanently consumed a concurrency slot; once exhausted, new requests waited in the pool until the connection closed. Neither the idle timeout nor the keep-alive expiry reclaims these slots. - HTTP/2: close the stream when it is reset before stream allocation. - HTTP/3: when the request headers were not sent, also abort the inbound side and close the stream channel, since Netty does not close it after a reset. Add reset and cancel tests covering all HTTP versions. Assisted-by: Anthropic Claude (claude-opus-5-5) Signed-off-by: Sean Riggin <sriggin@gmail.com>
Member
|
it seems your contribution has issues with CI, you should check the log and assess locally, perhaps it is regression or perhaps the tests are incorrectly written and do not pass anymore |
Contributor
Author
Yup, sorry! I missed running the broader test suite locally, which showed that another small change (2nd commit) was necessary for the close handler. |
Contributor
Author
|
@vietj This should be ready to go now, my miss in other tests has been addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resetting or cancelling an HttpClientRequest before anything was written did not close the stream on HTTP/2 and HTTP/3, so the connection lease was never recycled. Each such request permanently consumed a concurrency slot; once exhausted, new requests waited in the pool until the connection closed. Neither the idle timeout nor the keep-alive expiry reclaims these slots.
Add reset and cancel tests covering all HTTP versions.
Motivation:
We have a use-case where acquiring a connection/stream from the pool that takes time (say connection establishment) exceeds a dynamic latency budget and we want to release the connection/stream lease without using it.
cancel()appears to be the best fit but this bug prevents us from using it.Assisted-by: Anthropic Claude (claude-opus-5-5)