Repository navigation
[xess xmx] Don't hide Intel GPUs when XeSS is provided by Proton - #5992
Open
damian-tomczak-intel wants to merge 6 commits into
Open
damian-tomczak-intel wants to merge 6 commits into
damian-tomczak-intel wants to merge 6 commits into
Conversation
Contributor
Author
|
This is one of four [XeSS XMX] PRs that together add XMX-accelerated XeSS to Proton:
The Proton PR bumps the other three submodules, so it should go in last. |
This was referenced Oct 19, 2026
doitsujin
reviewed
Oct 19, 2026
doitsujin
reviewed
Oct 19, 2026
doitsujin
reviewed
Nov 2, 2026
| // doesn't use the Intel path that needs the workaround. | ||
| static const char builtinSignature[] = "Wine builtin DLL"; | ||
| bool isBuiltin = !std::memcmp(reinterpret_cast<const char*>(libxess) + 0x40, | ||
| builtinSignature, sizeof(builtinSignature)); |
Owner
There was a problem hiding this comment.
Isn't there a more robust way to detect this (e.g. some export that's only available in the built-in dll or something)?
This hack looks like the kind of thing that's just going to blow up either on Windows or at some point in the future, and when it does then the only real option is to remove the code.
|
|
||
| private: | ||
|
|
||
| mutable std::atomic<XessVendorWa> m_xessVendorWa = { XessVendorWa::Unknown }; |
Owner
There was a problem hiding this comment.
Can this just be a static variable inside the respective function or do we ever expect to have to do the workaround in one DXGI factory but not the other?
File version Windows API calls fail on the DLL intercept, and Proton-shipped XeSS library must be compatible with Linux environs.
Evaluate the XeSS Intel vendor workaround when adapters are enumerated rather than when DXGI options are constructed, since applications may load libxess.dll after startup. Cache a positive decision so later adapter queries remain consistent without repeatedly probing the module. Keep Intel visible when XeSS is absent or the configured library is known-good.
This reverts commit 5cc8a96.
damian-tomczak-intel
force-pushed
the
xess-release
branch
from
November 17, 2026 17:23
8cc421a to
903dcaf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skips the XeSS vendor workaround, which hides Intel GPUs from games with a libxess.dll older than 2.0.2.68, when XeSS is provided by Proton. Proton's libxess.dll is a Wine builtin forwarding to the Linux XeSS library, it has no version resource, so the check always failed and the Intel GPU was hidden.
The workaround is now also decided when adapters are enumerated instead of when the DXGI options are created, since games can load libxess.dll later. A positive decision is cached so later adapter queries stay consistent, and the decision is logged. dxgi.hideIntelGpu still overrides it.
Part of the [XeSS XMX] series, see the comment below for the other PRs.