Skip to content

2667 Reject AI Attribution - #2733

Open
stphschne wants to merge 59 commits into
devonfw:mainfrom
stphschne:2667-Reject-AI-Attribution-clean
Open

stphschne wants to merge 59 commits into
devonfw:mainfrom
stphschne:2667-Reject-AI-Attribution-clean

Conversation

@stphschne

@stphschne stphschne commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

This PR fixes #2667

Implemented changes:

  • Change 1: Added check-ai-attribution.sh to create error for AI-commits.
  • Change 2: Added new hook: commit-msg.
  • Change 3: Added new job in build-pr.yml(name: Check commit messages).
  • Change 4: Added new message in install-hooks.sh to inform about ai-attribution blockage.

Testing instructions

Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:

1.Open Git Bash
2.Run ./install-hooks.sh. commit-msg and check-ai-attribution should be active.
3.Run following tests:
1.cat > /tmp/ai-msg.txt <<EOF
#2667: Add commit check

Co-authored-by: Copilot copilot@github.com
EOF

git-hooks/check-ai-attribution.sh /tmp/ai-msg.txt
echo $?
Error expected. Should return 1.
2.cat > /tmp/human-msg.txt <<EOF
#2667: Add commit check

Co-authored-by: Max Mustermann max@example.com
EOF

git-hooks/check-ai-attribution.sh /tmp/human-msg.txt
echo $?
Should return 0.

3.cat > /tmp/generated-msg.txt <<EOF
#2591: Add commit check

Generated with Claude Code
EOF

git-hooks/check-ai-attribution.sh /tmp/generated-msg.txt
echo $?
Error expected. Should return 1.
4.Run following command:
git config --local core.hooksPath

Should return
git-hooks.


Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat and not feature/921 fixed setup.bat).
    If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labelled
    with internal
  • You have not changed any dependency in pom.xml files or otherwise if runtime dependencies changed,
    you have updated our LICENSE.adoc
  • You have formulated clear instructions on how to test your contribution under "Testing instructions"

Checklist for tool commandlets

Have you added a new «tool» as commandlet? There are the following additional checks:

  • The tool can be installed automatically (during setup via settings) or via the commandlet call
  • The tool is isolated in its IDEasy project, see Sandbox Principle
  • The new tool is added to the table of tools in LICENSE.asciidoc
  • The new commandlet is a command-wrapper for «tool»
  • Proper help texts for all supported languages are added here
  • The new commandlet installs potential dependencies automatically
  • The variables «TOOL»_VERSION and «TOOL»_EDITION are honored by your commandlet
  • The new commandlet is tested on all platforms it is available for or tested on all platforms that are in scope of the linked issue

Checklist for GUI contributions

Did you make user-facing changes to the GUI? There are the following additional checks:

  • You followed the ui-contribution-process.adoc and ui-structure.adoc
  • The UI changes are designed in the Figma project and the design was approved in the team review
  • You have added screenshots of the UI changes to the PR description

stphschne and others added 30 commits September 23, 2026 17:53
# Conflicts:
#	cli/src/test/java/com/devonfw/tools/ide/merge/PropertiesMergerTest.java
#	gui/src/main/java/com/devonfw/ide/gui/core/mainwindow/console/ConsoleView.java
#	gui/src/main/java/com/devonfw/ide/gui/core/mainwindow/console/ConsoleViewModel.java
…fixed integration tests for npm-based tools (devonfw#2601)

* devonfw#2596:
- fixed the way npm installs its tools, npm tools will now be installed into software/node_modules
- added clean up method to remove the newly added folder if no tool is installed anymore

* devonfw#2596:
- fixed npm_config_prefix path

* devonfw#2596:
- fixed integration tests

Co-authored-by: quando632 <quang-hieu.do@capgemini.com>

* Update cli/src/main/java/com/devonfw/tools/ide/tool/PackageManagerBasedLocalToolCommandlet.java

Co-authored-by: quando632 <quang-hieu.do@capgemini.com>

---------

Co-authored-by: quando632 <quang-hieu.do@capgemini.com>
…2604)

* Update documentation/contributing/contributing.adoc

Co-authored-by: Lukas <luk.faber@gmx.de>

---------

Co-authored-by: gkenstel <Ghino.Kenstel@Capgemini.com>
Co-authored-by: Lukas <luk.faber@gmx.de>
…alue co… (devonfw#2558)

* devonfw#2541: skip empty variable values in inverseResolve to avoid value corruption

* devonfw#2541: address PR review - drop redundant asserts and fix AAA order in inverseResolve test

---------

Co-authored-by: quando632 <quang-hieu.do@capgemini.com>
devonfw#2560)

* devonfw#2546: Add repository/working directory into git warning/errors

* devonfw#2546: Applied review

* devonfw#2546: edit CHANGELOG.adoc

---------

Co-authored-by: quando632 <quang-hieu.do@capgemini.com>
* Repaired the coding-convention link

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: quando632 <quang-hieu.do@capgemini.com>

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: quando632 <quang-hieu.do@capgemini.com>

---------

Co-authored-by: quando632 <quang-hieu.do@capgemini.com>
* devonfw#2440: Make IdeLauncherTab non-closeable

* devonfw#2440: Fixed tabfactorytest
* devonfw#2250:
- updated GlobalToolCommandletTest to verify uninstall via package manager commands
- added CapturingProcessContextTest to capture uninstall commands before execution and allow assertions without executing the actual commands

---------

Co-authored-by: Lukas <luk.faber@gmx.de>
Co-authored-by: quando632 <quang-hieu.do@capgemini.com>
- Reworked GUI architecture
- Split MainWindow and NavigationPanelControl into View/ViewModel
- Added TabComponent and reworked TabFactory
- Added EventBus integration to the GUI and TabFactory
- Reworked ConsoleController into ConsoleView and ConsoleViewModel
- Migrated console logging to use the EventBus
- Fixed console line count handling and formatting
- Added tests for EventBus and off-FX-thread console logging
- Updated UI structure documentation
- Removed unused NLS strings and methods
- Added JavaDocs and performed general cleanup
- Applied review recommendations and code review suggestions
- Fixed tests, Checkstyle, Spotless, and imports
- Resolved rebase/merge conflicts and performed post-merge cleanup
---------

Signed-off-by: laim2003 <luk.faber@gmx.de>
Co-authored-by: samuelkos17 <samuel.kos@outlook.com>
Co-authored-by: Samuel Kostiuk <148919667+samuelkos17@users.noreply.github.com>
@github-project-automation github-project-automation Bot moved this to 🆕 New in IDEasy board Oct 22, 2026
@stphschne stphschne added AI artificial intelligence, GenAI, etc. internal Nothing to be added to CHANGELOG, only internal story enhancement New feature or request labels Oct 22, 2026
@stphschne
stphschne requested review from quando632 and removed request for quando632 October 22, 2026 14:39
@stphschne stphschne changed the title 2667 reject ai attribution clean 2667 Reject AI Attribution Oct 22, 2026
@stphschne stphschne moved this from 🆕 New to Team Review in IDEasy board Oct 22, 2026
@stphschne
stphschne force-pushed the 2667-Reject-AI-Attribution-clean branch from 2de5a71 to 2ebaffc Compare October 22, 2026 17:02
@coveralls

coveralls commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Coverage Report for CI Build 40359343517

Coverage decreased (-0.01%) to 75.082%

Details

  • Coverage decreased (-0.01%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 1 coverage regression across 1 file.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
com/devonfw/tools/ide/version/VersionSegment.java 1 89.76%

Coverage Stats

Coverage Status
Relevant Lines: 19769
Covered Lines: 15497
Line Coverage: 78.39%
Relevant Branches: 8793
Covered Branches: 5948
Branch Coverage: 67.64%
Branches in Coverage %: Yes
Coverage Strength: 3.37 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI artificial intelligence, GenAI, etc. enhancement New feature or request internal Nothing to be added to CHANGELOG, only internal story

Projects

Status: Team Review

Development

Successfully merging this pull request may close these issues.

Reject AI attribution in commits with a commit-msg hook and a CI check