Repository navigation
Conversation
…rage to 100%(line).
…rage to 100%(line).
# Conflicts: # cli/src/test/java/com/devonfw/tools/ide/merge/PropertiesMergerTest.java # gui/src/main/java/com/devonfw/ide/gui/core/mainwindow/console/ConsoleView.java # gui/src/main/java/com/devonfw/ide/gui/core/mainwindow/console/ConsoleViewModel.java
…fixed integration tests for npm-based tools (devonfw#2601) * devonfw#2596: - fixed the way npm installs its tools, npm tools will now be installed into software/node_modules - added clean up method to remove the newly added folder if no tool is installed anymore * devonfw#2596: - fixed npm_config_prefix path * devonfw#2596: - fixed integration tests Co-authored-by: quando632 <quang-hieu.do@capgemini.com> * Update cli/src/main/java/com/devonfw/tools/ide/tool/PackageManagerBasedLocalToolCommandlet.java Co-authored-by: quando632 <quang-hieu.do@capgemini.com> --------- Co-authored-by: quando632 <quang-hieu.do@capgemini.com>
…2604) * Update documentation/contributing/contributing.adoc Co-authored-by: Lukas <luk.faber@gmx.de> --------- Co-authored-by: gkenstel <Ghino.Kenstel@Capgemini.com> Co-authored-by: Lukas <luk.faber@gmx.de>
…alue co… (devonfw#2558) * devonfw#2541: skip empty variable values in inverseResolve to avoid value corruption * devonfw#2541: address PR review - drop redundant asserts and fix AAA order in inverseResolve test --------- Co-authored-by: quando632 <quang-hieu.do@capgemini.com>
devonfw#2560) * devonfw#2546: Add repository/working directory into git warning/errors * devonfw#2546: Applied review * devonfw#2546: edit CHANGELOG.adoc --------- Co-authored-by: quando632 <quang-hieu.do@capgemini.com>
* Repaired the coding-convention link * Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: quando632 <quang-hieu.do@capgemini.com> * Update .github/PULL_REQUEST_TEMPLATE.md Co-authored-by: quando632 <quang-hieu.do@capgemini.com> --------- Co-authored-by: quando632 <quang-hieu.do@capgemini.com>
* devonfw#2440: Make IdeLauncherTab non-closeable * devonfw#2440: Fixed tabfactorytest
* devonfw#2250: - updated GlobalToolCommandletTest to verify uninstall via package manager commands - added CapturingProcessContextTest to capture uninstall commands before execution and allow assertions without executing the actual commands --------- Co-authored-by: Lukas <luk.faber@gmx.de> Co-authored-by: quando632 <quang-hieu.do@capgemini.com>
- Reworked GUI architecture - Split MainWindow and NavigationPanelControl into View/ViewModel - Added TabComponent and reworked TabFactory - Added EventBus integration to the GUI and TabFactory - Reworked ConsoleController into ConsoleView and ConsoleViewModel - Migrated console logging to use the EventBus - Fixed console line count handling and formatting - Added tests for EventBus and off-FX-thread console logging - Updated UI structure documentation - Removed unused NLS strings and methods - Added JavaDocs and performed general cleanup - Applied review recommendations and code review suggestions - Fixed tests, Checkstyle, Spotless, and imports - Resolved rebase/merge conflicts and performed post-merge cleanup --------- Signed-off-by: laim2003 <luk.faber@gmx.de> Co-authored-by: samuelkos17 <samuel.kos@outlook.com> Co-authored-by: Samuel Kostiuk <148919667+samuelkos17@users.noreply.github.com>
stphschne
force-pushed
the
2667-Reject-AI-Attribution-clean
branch
from
October 22, 2026 17:02
2de5a71 to
2ebaffc
Compare
stphschne
commented
Oct 23, 2026
Collaborator
Coverage Report for CI Build 40359343517Coverage decreased (-0.01%) to 75.082%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2667
Implemented changes:
Testing instructions
Please add conscise, understandable instructions on how a reviewer can test/verify the functionality of your contribution here:
1.Open Git Bash
2.Run ./install-hooks.sh. commit-msg and check-ai-attribution should be active.
3.Run following tests:
1.cat > /tmp/ai-msg.txt <<EOF
#2667: Add commit check
Co-authored-by: Copilot copilot@github.com
EOF
git-hooks/check-ai-attribution.sh /tmp/ai-msg.txt
echo $?
Error expected. Should return 1.
2.cat > /tmp/human-msg.txt <<EOF
#2667: Add commit check
Co-authored-by: Max Mustermann max@example.com
EOF
git-hooks/check-ai-attribution.sh /tmp/human-msg.txt
echo $?
Should return 0.
3.cat > /tmp/generated-msg.txt <<EOF
#2591: Add commit check
Generated with Claude Code
EOF
git-hooks/check-ai-attribution.sh /tmp/generated-msg.txt
echo $?
Error expected. Should return 1.
4.Run following command:
git config --local core.hooksPath
Should return
git-hooks.
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat).If no issue ID exists, title only.
In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed,you have updated our LICENSE.adoc
Checklist for tool commandlets
Have you added a new
«tool»as commandlet? There are the following additional checks:«tool»«TOOL»_VERSIONand«TOOL»_EDITIONare honored by your commandletChecklist for GUI contributions
Did you make user-facing changes to the GUI? There are the following additional checks: