Repository navigation
Conversation
Convert search trigger elements in sidebar and footer templates from unlinked <a> tags to semantic <button type="button"> elements with focus-visible ring styles. This restores keyboard navigation, native Space/Enter triggering, and proper screen reader semantics. Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
💡 What
Converted search triggers from unlinked
<a>tags withcursor-pointerto semantic<button type="button">elements withfocus-visiblering styling intemplates/components/sidebar.tplandtemplates/components/footer.tpl.🎯 Why
In HTML, an
<a>element without anhrefattribute is not a hyperlink. As a consequence, it is omitted from default keyboard tab navigation sequences and cannot be activated via standard keyboard interactions (Enter/Space), hindering screen reader and keyboard-only users from accessing the search trigger.♿ Accessibility
<button type="button">.focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-offset-2 focus-visible:ring-${theme}-500 roundedto provide clear keyboard focus feedback aligned with the site's dynamic theme tokens.PR created automatically by Jules for task 11898094966202204265 started by @dezren39
Need help on this PR? Tag
@codesmith-botwith what you need.