Skip to content

🎨 Palette: Use semantic button with focus-visible styling for search modal triggers - #32

Draft
dezren39 wants to merge 1 commit into
mainfrom
palette/search-button-a11y-11898094966202204265
Draft

dezren39 wants to merge 1 commit into
mainfrom
palette/search-button-a11y-11898094966202204265

Conversation

@dezren39

@dezren39 dezren39 commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

💡 What

Converted search triggers from unlinked <a> tags with cursor-pointer to semantic <button type="button"> elements with focus-visible ring styling in templates/components/sidebar.tpl and templates/components/footer.tpl.

🎯 Why

In HTML, an <a> element without an href attribute is not a hyperlink. As a consequence, it is omitted from default keyboard tab navigation sequences and cannot be activated via standard keyboard interactions (Enter / Space), hindering screen reader and keyboard-only users from accessing the search trigger.

♿ Accessibility

  • Replaces non-semantic anchor tags with native <button type="button">.
  • Restores keyboard tab navigation and activation without relying on mouse clicks.
  • Adds focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-offset-2 focus-visible:ring-${theme}-500 rounded to provide clear keyboard focus feedback aligned with the site's dynamic theme tokens.

PR created automatically by Jules for task 11898094966202204265 started by @dezren39


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Convert search trigger elements in sidebar and footer templates
from unlinked <a> tags to semantic <button type="button"> elements
with focus-visible ring styles. This restores keyboard navigation,
native Space/Enter triggering, and proper screen reader semantics.

Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Nov 2, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

This branch was previously deployed

1 inactive deployment
ci — 81be8d50 Deployed Nov 2, 2026 by dezren39 via ci #356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant