Repository navigation
Conversation
A fighter docked inside the carrier has no Transform (docking.cpp removes it on internal docking), so getPosition() returns nothing and distance() errors in closestPlayerTo/farthestPlayerFrom. Five such errors in a row stop update() for the rest of the game, which happens as soon as a fighter docks - the scenario's own setup. Also: - freighter cargo list read comms_target.goods (nil); the guard and the other uses say comms_target.comms_data.goods - carrier custom-button cleanup, reputation bumps and doNotPush skip a destroyed carrier/player ship (destroyed entities keep only isValid) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a fighter docks inside the carrier,
docking.cppremoves its Transform.getPosition()then returns nothing, anddistance()errors inclosestPlayerToandfarthestPlayerFrom. Five errors in a row stopupdate()for the rest of the game, which happens as soon as a fighter docks.Also:
comms_target.goods(nil); the guard just above it usescomms_target.comms_data.goodsdoNotPushskip a destroyed carrier or player shipTesting: an automated headless run had
update()stop. After the fix it flew without errors. The cargo typo error appeared when asking a freighter "Where are you headed?".🤖 Generated with Claude Code