Repository navigation
Honor a safe path on Python 3.10 via the compat.py310 shim - #28
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PYTHONSAFEPATH keeps the cwd off sys.path so a project module can't shadow a stdlib import — but it was added in 3.11 and is a silent no-op on 3.10. So when coherent.test runs from a repo root that contains stdlib-shadowing modules (e.g. compilers.common ships
platform/andlogging.py), the 3.10 matrix leg crashes: first in coherent.test's own import chain (pip_run->jaraco.context->platform.system()), then in the innerpython -m pytestsubprocess (_pytest.logging->import logging).Retain PYTHONSAFEPATH as the preferred mechanism and cover 3.10 with the
jaraco.compat.py310.safe_pathshim:core.pyso its side effect strips the cwd before the shadow-prone imports run.-cbootstrap on 3.10 that imports the shim (stripping cwd) before importing pytest. Isolated mode (-I) would also drop PYTHONPATH, which build_env relies on, so it can't be used here.Verified on 3.10 and 3.13: compilers.common now passes (15) and coherent.test's own suite is unaffected (12).
Ref coherent-oss/system#34.