Skip to content

Settlement test: make 'logs a failed PR lookup once per project across sweeps' exercise a second failing sweep #127

Open

Description

@chrisohearn

Follow-up from the #125 upstream merge (P3, test coverage).

Upstream's sweep now stamps a failed branch lookup and skips it until it is due again (noPullRequestRechecks). The fork test "logs a failed PR lookup once per project across sweeps without settling it" (ThreadSettlementService.test.ts) now sees one lookup per branch, and its assertion was updated to 2. The second sweep therefore no longer looks the branches up again. The test still checks that one log is written, but no longer proves that a second sweep with fresh failures stays quiet.

Fix: advance the test clock past the recheck delay before the second sweep, or call the lookup through a thread-triggered sweep, so the second sweep fails again. Then assert there is still one log.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions