Skip to content

Title regeneration: use recorded fork run exclusions instead of rollback-time estimate #126

Open

Description

@chrisohearn

Follow-up from the #125 upstream merge (P3).

Fork inheritance reads the run exclusions recorded when a fork was made (fork_run_exclusions). Upstream's new thread title regeneration (ThreadTitleRegenerationService.messagesThroughRun) reads a fork's source history through ThreadManagement, which does not expose those exclusions. #125 therefore keeps upstream's rollback-time estimate for it, as forkInheritedRunOrdinalsAt in ProjectionStore.ts.

Effect: when a run's rollback time and the fork time disagree with the recorded exclusions, a regenerated fork title may count or skip that run's messages differently from the fork's visible history. This affects title context only.

Fix: expose the recorded exclusions (or the inherited run ordinals) through ThreadManagement and use them in title regeneration, then remove forkInheritedRunOrdinalsAt.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions