Repository navigation
r3b.c2: carry the battery manufacture-date fix (#1615) on r3b.c1 - #150
Merged
Merged
Conversation
r3b to r3b.c1 left out sleep-lid/0007. On this Mac every r3b boot then logs manufacture_year -95, the battery's uevent fails, udev never handles macsmc-battery, and a saved charge limit is not restored: an 80% limit read 100 after a reboot into r3b.c1 (2026-11-16). r3a carries the fix, but since the D9 promotion r3b is the default kernel. r3b.c2 is r3b.c1 plus that patch, unchanged. PKGBUILD gets the r3b-c2 candidate and refuses a tree without the fix. The r3b.series note that called the patch unneeded is corrected. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
patches/linux/r3b-c2.series: r3b.c1 plussleep-lid/0007, the same file r3a carries (power: supply: macsmc: skip an unreadable manufacture date quietly aurora-silicon/linux#1615).packaging/linux-k114s/PKGBUILD:r3b-c2candidate, version7.3.0.r3b.c2-1, with the same package name and release as r3b.c1, so it upgrades in place.patches/linux/r3b.series: corrects the note that called the patch "not needed".docs/r3b-kernel.mdsection 10, and the battery row ofdocs/matrix.md.Why
Seen on this Mac on 2026-11-16:
/etc/udev/macsmc-battery.confholds 80.charge_control_end_thresholdread 100.manufacture_year ... -95, and udev had no record ofmacsmc-batterybeyond its path. So neither the asahi-scripts nor the Omarchy restore rule ran.r3a has the fix, but since the D9 promotion r3b is the default kernel.
Proof (agent-run)
git amof the patch on r3b.c108ddebb521gives headecbecd26ad, treee078a06e67c5.K114S_LABEL=K114S-R3B-C2) exits 0 with no warning indrivers/power/supplyordrivers/gpu/drm/apple.k114s-cmp-modulesagainst the installed r3b.c1: 1972 of 1972 modules are the same (macsmc-poweris built in).makepkg, thencheck-package.shagainstlinux-auroraandlinux-k114s: all passed.57dfac86c2a51d73847a7e3e114fc1eb7b378282a73ca4b4c94ab5b6be8ed20f.tests/linux/run-r3.sh: every suite passes.Not booted yet. The owner-watched install and reboot, with the charge-limit read-back, come next.
🤖 Generated with Claude Code