Repository navigation
Prevent credentials in source, cluster and diff diagnostics - #1144
Open
sameerforge wants to merge 1 commit into
Open
sameerforge wants to merge 1 commit into
sameerforge wants to merge 1 commit into
Conversation
Sanitize HTTP source descriptions, nested request errors and target-cluster URLs without changing request authentication. Apply default Secret masking rules to tools diff, preserving the explicit masking opt-out. Add regression coverage for authenticated requests and both diff output modes. Signed-off-by: Sameer Khan <sameer.khan@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Sanitize HTTP input URLs in source descriptions and errors, including nested URL errors, and sanitize the target-cluster banner. Apply the standard Secret masking rules to
tools diffin both text and YAML modes, while preserving--mask=falseand the original inputs used for authentication and deployment.Validation
go test ./internal/diagnostics ./pkg/...golangci-lint rundata/stringData, both diff output modes and the explicit masking opt-out.Does this PR introduce a user-facing change?