Repository navigation
Conversation
Resuming a deployment can leave an unchanged resource still reconciling. Treating it as a no-op in the change graph lets dependent resources proceed before it is ready. Include unchanged resources in upsert ordering to retain their change rules and transitive dependencies. Remove references to pruned changes so completed prerequisites do not leave dependents blocked. Add unit coverage for ordering, dependency chains, completed and failed prerequisites, and disabled waiting, plus an end-to-end regression using a suspended Job. Fixes carvel-dev#729 Signed-off-by: Himanshu Singh <himansh.singh3@gmail.com>
himsngh
force-pushed
the
fix/729-noop-dependency-ordering
branch
from
October 26, 2026 07:20
bb36583 to
cbe96d5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Resuming a deployment can leave an unchanged resource still reconciling. Treating it as a no-op in the change graph lets dependent resources proceed before it is ready.
Include unchanged resources in upsert ordering to retain their change rules and transitive dependencies. Remove references to pruned changes so completed prerequisites do not leave dependents blocked.
Add unit coverage for ordering, dependency chains, completed and failed prerequisites, and disabled waiting, plus an end-to-end regression using a suspended Job.
Which issue(s) this PR fixes:
Fixes #729
Does this PR introduce a user-facing change?
Additional Notes for your reviewer:
Review Checklist:
a link to that PR
change
Additional documentation e.g., Proposal, usage docs, etc.: