Repository navigation
Added a log message and made umount idempotent - #30
Merged
Merged
Conversation
wknapik
marked this pull request as ready for review
September 1, 2026 15:08
wknapik
enabled auto-merge (squash)
September 1, 2026 15:10
mihaiplesa
previously approved these changes
Sep 1, 2026
There was a problem hiding this comment.
🟡 Changes recommended
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the vol CLI script to improve operational UX by making unmount operations idempotent and adding additional debug logging around volume state transitions (per Issue #25).
Changes:
- Make
umount(mountpoint)a no-op (with messaging) when the path is not a mountpoint. - Add a debug log when a volume reaches a valid state in
wait_for_volume. - Minor formatting adjustment in
run()options construction.
File summaries
| File | Description |
|---|---|
vol |
Adds a new debug log in wait_for_volume and makes umount idempotent by gating the unmount call on os.path.ismount(). |
Review details
Suppressed comments (1)
vol:590
umount()always logs "Unmounting …" even when the path is not a mountpoint; with the new idempotent behavior this message becomes inaccurate/confusing. Log the unmount action only whenismount(mountpoint)is true.
def umount(mountpoint, force = False):
msg(f'Unmounting {mountpoint}')
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
auto-merge was automatically disabled
September 1, 2026 15:20
Head branch was modified
mihaiplesa
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #25
(we could verify that the expected volume is mounted at the supplied mountpoint, and not something else, but I'm treating it as the script caller's concern)