Repository navigation
Conversation
Collaborator
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
reversed: trueis set withoutstart, the start number is taken fromitems.length. That count also includes items that are nested lists ({ ol: [...] }/{ ul: [...] }). Those items get no marker and don't change the counter, so the list starts too high and never reaches 1.Before:
3., (nested list),2.After:
2., (nested list),1.The default start now counts only the items that actually get a marker, which matches how non-reversed lists already skip nested lists when numbering. Lists with an explicit
startare unchanged.I added a unit test in
tests/unit/DocMeasure.spec.jsand a CHANGELOG entry.npm run mochagives 615 passing, andnpm run lintis clean.