Repository navigation
genesis: parse stabilityWindowFactor as a double and document it - #190
Merged
Merged
Conversation
The admin-update merge path parsed this double field with Integer.parseInt, so any fractional value (the only useful kind) threw. The properties-file path already bound it correctly. - parse with Double.parseDouble in GenesisConfig.merge - explain the k derivation and the idle tolerance it fixes in the node-configuration page and in node.properties
satran004
approved these changes
Sep 23, 2026
8 of 12 tasks
satran004
added a commit
that referenced
this pull request
Sep 26, 2026
Brings in #188 (relay sync wait by progress), #189 (slot-leader time travel below f=1) and #190 (stabilityWindowFactor as a double). - YanoConfigBuilder.build() takes the history dir, #189's slot-leader flag and the backfill interval; YanoService keeps both settings and passes both - application.properties, both node.properties and the node-modes / node-configuration docs keep every section; the node.properties examples keep slotsPerKESPeriod=10000000 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The admin-update merge path parsed this double field with Integer.parseInt, so any fractional value (the only useful kind) threw. The properties-file path already bound it correctly.