Repository navigation
Deliver artifact changes through shared live routes - #1480
Conversation
Co-authored-by: OpenAI Codex <codex@openai.com> Signed-off-by: drouleau <drouleau@squareup.com> Co-authored-by: Codex <noreply@openai.com>
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
🤖 Star Lord automated source review via Wes's account, integrating independent Rocket, Mantis and Groot reviews.
No actionable source defects found. Assessment: 9/10 for minimalness, ownership and source correctness.
Reviewed head ffcba58 against base d9793a8; the four-file PR delta starts at merge base 1311492. Kind 45010 uses the existing native/browser live owner, access filtering, replay bounds and retirement fences. The added test source covers singleton and batched delivery plus rejection after membership removal. Artifact arrivals do not add chat unread/activity or refresh SharedSessions; explicitly configured event watches retain their generic matching behavior. The public PR description and commit metadata were inspected; the description has no attached images.
Optional documentation wording: in docs/shared-plugin-services.md:70, naming outbox.retry(operationId) would make “retry the same operation” more concrete. This is not a requested correctness fix.
Validation limits: source-only review; no PR code, tests, builds or app were run. One hosted-check snapshot showed executed checks successful, with Windows native validation and browser flake checks skipped. Live relay/native behavior, artifact-heavy performance, reconnect recovery in a real plugin, UI focus/retry behavior and human acceptance remain unverified. This COMMENT is not an approval or merge authorization.
Co-authored-by: Codex <noreply@openai.com> Signed-off-by: Daniel Rouleau <drouleau@squareup.com>
wesbillman
left a comment
wesbillman
left a comment
There was a problem hiding this comment.
🤖 Star Lord automated source review via Wes's account.
No actionable findings in this follow-up. Assessment: 9/10 for minimalness, ownership and source correctness.
Reviewed head e13425e against base d9793a8 (merge base 1311492). Used the small-follow-up solo exception: the endpoint comparison with previously reviewed ffcba58 changes only two documentation files, deleting the broad plugin-services guide and its incoming link. All production code and tests are unchanged from the prior Rocket/Mantis/Groot/Star Lord review. No new independent team review is claimed. No references to the deleted filename remain in the current tracked tree; the surrounding plugin lifecycle and relay ownership guidance remains intact. The earlier optional wording suggestion disappears with the removed guide.
Inspected the public PR description and both commit messages; no attached images are present in the description and no evident sensitive publication material was found. The description reports native acceptance at the unchanged feature commit; I did not independently reproduce it.
Validation limits: source and documentation review only; git diff --check passed. No tests, builds, app launches or PR code execution. One hosted-check snapshot showed successful completed checks, browser and Rust jobs still running/queued, and Windows native/browser-flake checks skipped. No behavior or focus/retry transitions change in this follow-up; native/live behavior, performance, rendered accessibility and human acceptance remain unverified by this cycle. This COMMENT is not an approval or merge authorization.
…e-skip-archived-channels * origin/main: Bump tokio to 1.53.3 for RUSTSEC-2026-0386 (#1581) Unify attachment cards with neutral icon tiles (#1548) Polish edit context, channel join and profile actions (#1545) fix(claude-code): keep context across channel threads (#1516) fix(builderlab): let Create agent cancel a pending browser sign-in (#1526) test(sidebar-filters): start the focus journey on General (#1555) Add opt-in native MCP for macOS tests (#1528) Show unreads for channels after access changes (#1550) Deliver artifact changes through shared live routes (#1480) condense photo and video attachments into a compact grid (#1549) Signed-off-by: John Tennant <jtennant@block.xyz>
Signed-off-by: morgmart <98432065+morgmart@users.noreply.github.com> Co-authored-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * origin/main: (24 commits) Unify chat and channel access, tidy the Solo chat menu (#1446) fix(todos): render nested TODOs with collapsible hierarchy and Markdown (#1483) fix(agents): Allow agents to propose updates to agents (#1478) fix(composer): prevent plugins from updating the recipient on a WIP draft message (#1497) fix(agents): can't delete an agent belonging to an archived channel (#1560) Bump tokio to 1.53.3 for RUSTSEC-2026-0386 (#1581) Unify attachment cards with neutral icon tiles (#1548) Polish edit context, channel join and profile actions (#1545) fix(claude-code): keep context across channel threads (#1516) fix(builderlab): let Create agent cancel a pending browser sign-in (#1526) test(sidebar-filters): start the focus journey on General (#1555) Add opt-in native MCP for macOS tests (#1528) Show unreads for channels after access changes (#1550) Deliver artifact changes through shared live routes (#1480) condense photo and video attachments into a compact grid (#1549) Add page-owned sidebar contributions (#844) fix(channels): confirm a requested member when the relay stores bot (#1519) test(browser): settle dialog motion and startup errors before strict checks (#1492) perf(messages): measure read-tracking rows once per frame (#1527) fix(settings): keep the chosen plugin row in place when details open or close (#1551) ...
…ocus * origin/main: (35 commits) fix(goose): say a provider isn't set up instead of offering placeholder models (block#1543) fix(agent-activity): note under a message when its agent was stopped (block#1544) feat(messages): show whose agent wrote a message (block#1502) feat(agents): put main agent choice in the card's actions menu (block#1530) fix(relay): let live dev connections save config artifacts (block#1583) feat(builderlab): let local agents create, deploy, share and open Builderlab apps (block#1340) Unify chat and channel access, tidy the Solo chat menu (block#1446) fix(todos): render nested TODOs with collapsible hierarchy and Markdown (block#1483) fix(agents): Allow agents to propose updates to agents (block#1478) fix(composer): prevent plugins from updating the recipient on a WIP draft message (block#1497) fix(agents): can't delete an agent belonging to an archived channel (block#1560) Bump tokio to 1.53.3 for RUSTSEC-2026-0386 (block#1581) Unify attachment cards with neutral icon tiles (block#1548) Polish edit context, channel join and profile actions (block#1545) fix(claude-code): keep context across channel threads (block#1516) fix(builderlab): let Create agent cancel a pending browser sign-in (block#1526) test(sidebar-filters): start the focus journey on General (block#1555) Add opt-in native MCP for macOS tests (block#1528) Show unreads for channels after access changes (block#1550) Deliver artifact changes through shared live routes (block#1480) ... Signed-off-by: user-kWN3CIVowEvEo3RM <joelrobotham+bbprod@gmail.com> # Conflicts: # tests/browser/github-body.spec.mjs
Why
Plugins miss artifact changes from other clients because shared live routes omit kind
45010.What
Include artifact events in the existing live routes. Cover delivery and channel access removal with regression tests.
How
The browser broker and native transport share the same live owner. The change adds one production line and uses the existing signing, permissions, outbox, and runner.
Risk
Live routes receive more events in channels that contain artifacts. Existing access filters and replay limits still apply.
Testing
Native macOS check at
ffcba58f50709a16dcc4e11013d654f6ad89d96f: a temporary plugin creates a private channel and publishes an artifact. The human runs the check. The agent verifies the screenshot: queued and verified live markers both equallive-check-1792603225121. This checks the native signing and live relay path.The source and regression tests match the validated commit. Browser journeys added/removed: 0. Native reconnect and load tests are outside this check.
buzz-review-completed
Generated with Codex